diff options
| author | Pierre Gondois <pierre.gondois@arm.com> | 2022-04-27 16:49:31 +0200 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2022-07-18 12:44:09 +0000 |
| commit | fc4a132c0e9d108d30115cb8729f8fcd5564b855 (patch) | |
| tree | 5c4ee578483ca2868893d76cb59dfa3363e679bb /DynamicTablesPkg/Library/Acpi/Arm | |
| parent | 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 (diff) | |
| download | edk2-fc4a132c0e9d108d30115cb8729f8fcd5564b855.zip edk2-fc4a132c0e9d108d30115cb8729f8fcd5564b855.tar.gz edk2-fc4a132c0e9d108d30115cb8729f8fcd5564b855.tar.bz2 | |
DynamicTables: Fix DT PCI interrupt flags parsing
Device Tree PCI interrupt flags use the convention described at
linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
The 3rd cell is the flags, encoded as follows:
bits[3:0] trigger type and level flags.
1 = low-to-high edge triggered
2 = high-to-low edge triggered (invalid for SPIs)
4 = active high level-sensitive
8 = active low level-sensitive (invalid for SPIs).
Fix the incorrect code.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Diffstat (limited to 'DynamicTablesPkg/Library/Acpi/Arm')
| -rw-r--r-- | DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c index a340181..626e53d 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c @@ -449,7 +449,7 @@ GeneratePrt ( if ((Index > 0) &&
(IrqMapInfo->IntcInterrupt.Interrupt >= 32) &&
(IrqMapInfo->IntcInterrupt.Interrupt < 1020) &&
- ((IrqMapInfo->IntcInterrupt.Flags & 0x3) != BIT0))
+ ((IrqMapInfo->IntcInterrupt.Flags & 0xB) != 0))
{
Status = EFI_INVALID_PARAMETER;
ASSERT_EFI_ERROR (Status);
|