diff options
author | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2017-02-24 18:01:12 +0000 |
---|---|---|
committer | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2017-02-27 16:10:33 +0000 |
commit | 4b1dd5c457c8fb07937851c9dc0f38e48d130b14 (patch) | |
tree | ec2374aa2ac82756fd9ea84cf7070d9de496d9ad /BeagleBoardPkg | |
parent | 9fba024ed8f7b2099b598ad89571a22d7b70c3e1 (diff) | |
download | edk2-4b1dd5c457c8fb07937851c9dc0f38e48d130b14.zip edk2-4b1dd5c457c8fb07937851c9dc0f38e48d130b14.tar.gz edk2-4b1dd5c457c8fb07937851c9dc0f38e48d130b14.tar.bz2 |
ArmVirtPkg: clear PcdPerformanceLibraryPropertyMask PCD
The only observeable effect of having PcdPerformanceLibraryPropertyMask
set to 1 is that a EfiReservedMemory region of 4 pages is allocated right
below the 4 GB mark. This region is out of bounds for the OS, which means
it is not even allowed to map it, to avoid speculative loads from it.
On Linux, this may prevent the kernel from using a 1 GB block mapping for
this region, and instead it has to carve up the block as follows:
0xffffffff80000000-0xffffffffbe000000 992M PMD CON BLK
0xffffffffbe000000-0xffffffffbfe00000 30M PMD BLK
0xffffffffbfe00000-0xffffffffbfff0000 1984K PTE CON
0xffffffffbfff0000-0xffffffffbfffc000 48K PTE
where it would otherwise use a single 1 GB mapping (*), i.e.,
0xffffffff80000000-0xffffffffc0000000 1G PGD
To clarify, the latter is a single 8 byte entry in the top level page
table, whereas in the former case, we have two additional levels of
paging, requiring two extra 4 KB pages (on a 4 KB pagesize kernel).
The real cost, however, is the TLB footprint, which goes up from a
single entry to a number between 90 and 1020, depending on whether
contiguous hints are honoured by the hardware.
So let's remove PcdPerformanceLibraryPropertyMask until we find a reason
why we need it.
(*) provided that no other allocations were deliberately located right
below the 4 GB mark, and that we are running with more than 3 GB of
memory, in which case most allocations will be over 4 GB, given EDK2's
default top-down allocation policy.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Diffstat (limited to 'BeagleBoardPkg')
0 files changed, 0 insertions, 0 deletions