diff options
author | Michael D Kinney <michael.d.kinney@intel.com> | 2024-02-18 12:59:50 -0800 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2024-02-27 19:28:19 +0000 |
commit | 0bbec15b549032f239f0b05a725598f719d74325 (patch) | |
tree | cd37d099027a9eb4c736325a70617fd873fea3be /BaseTools/Scripts | |
parent | 45ad13bb6445e18e339311962dc7eaedb8df1d6c (diff) | |
download | edk2-0bbec15b549032f239f0b05a725598f719d74325.zip edk2-0bbec15b549032f239f0b05a725598f719d74325.tar.gz edk2-0bbec15b549032f239f0b05a725598f719d74325.tar.bz2 |
BaseTools/Scripts/PatchCheck: Error if no Cc tags are present
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694
If no Cc tags are detected in a commit message, then generate an
error. All patches sent for review are required to provide the set
of maintainers and reviewers responsible for the directories/files
modified. The set of maintainers and reviewers are documented in
Maintainers.txt and can be retrieved using the script
BaseTools/Scripts/GetMaintainer.py.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
Diffstat (limited to 'BaseTools/Scripts')
-rwxr-xr-x | BaseTools/Scripts/PatchCheck.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 158a2b3..415198e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -229,8 +229,10 @@ class CommitMessageCheck: )
def check_misc_signatures(self):
- for sig in self.sig_types:
- self.find_signatures(sig)
+ for sigtype in self.sig_types:
+ sigs = self.find_signatures(sigtype)
+ if sigtype == 'Cc' and len(sigs) == 0:
+ self.error('No Cc: tags for maintainers/reviewers found!')
cve_re = re.compile('CVE-[0-9]{4}-[0-9]{5}[^0-9]')
|