diff options
| author | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2016-07-01 12:29:37 +0200 |
|---|---|---|
| committer | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2016-07-01 13:24:25 +0200 |
| commit | f9ebccec096742465c0dfbbbb123d2c39f554d40 (patch) | |
| tree | 5af35ca277ed52a8c8103be7e888a26987f90d82 | |
| parent | 87f66b63d409fde7d2ea018b65a63986ba413f1f (diff) | |
| download | edk2-f9ebccec096742465c0dfbbbb123d2c39f554d40.zip edk2-f9ebccec096742465c0dfbbbb123d2c39f554d40.tar.gz edk2-f9ebccec096742465c0dfbbbb123d2c39f554d40.tar.bz2 | |
ArmPkg/DefaultExceptionHandlerLib: put ASSERT (FALSE) last
Putting DEBUG () code after an ASSERT (FALSE) statement is not very
useful, since the code will be unreachable on DEBUG builds and compiled
out on RELEASE builds. So move the ASSERT () statement after it.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
| -rw-r--r-- | ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c index 45a166a..31fc936 100644 --- a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c @@ -191,7 +191,6 @@ DefaultExceptionHandler ( DEBUG ((EFI_D_ERROR, "\n ESR : EC 0x%02x IL 0x%x ISS 0x%08x\n", (SystemContext.SystemContextAArch64->ESR & 0xFC000000) >> 26, (SystemContext.SystemContextAArch64->ESR >> 25) & 0x1, SystemContext.SystemContextAArch64->ESR & 0x1FFFFFF ));
DescribeExceptionSyndrome (SystemContext.SystemContextAArch64->ESR);
- ASSERT (FALSE);
DEBUG ((EFI_D_ERROR, "\nStack dump:\n"));
for (Offset = -256; Offset < 256; Offset += 32) {
@@ -204,5 +203,6 @@ DefaultExceptionHandler ( *(UINT64 *)(SystemContext.SystemContextAArch64->SP + Offset + 24)));
}
+ ASSERT (FALSE);
CpuDeadLoop ();
}
|