diff options
author | klu2 <klu2@6f19259b-4bc3-4df7-8a09-765794883524> | 2006-08-15 10:40:42 +0000 |
---|---|---|
committer | klu2 <klu2@6f19259b-4bc3-4df7-8a09-765794883524> | 2006-08-15 10:40:42 +0000 |
commit | f889b75c5fbbbb549c9299b7193957e6e59b636d (patch) | |
tree | fe0c7bcde67b6aef47f7c6972e10cd4a54e7d47b | |
parent | 94f446c081c1cd2cbc5f2b878a155cc2b59aa044 (diff) | |
download | edk2-f889b75c5fbbbb549c9299b7193957e6e59b636d.zip edk2-f889b75c5fbbbb549c9299b7193957e6e59b636d.tar.gz edk2-f889b75c5fbbbb549c9299b7193957e6e59b636d.tar.bz2 |
Fix track EDKT179.
In fact, I remove the judgment for unmached PCD value. because the checking work should be done in wizard tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@1276 6f19259b-4bc3-4df7-8a09-765794883524
-rw-r--r-- | Tools/Source/PcdTools/org/tianocore/pcd/action/PlatformPcdPreprocessAction.java | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/Tools/Source/PcdTools/org/tianocore/pcd/action/PlatformPcdPreprocessAction.java b/Tools/Source/PcdTools/org/tianocore/pcd/action/PlatformPcdPreprocessAction.java index c432b8c..9343c16 100644 --- a/Tools/Source/PcdTools/org/tianocore/pcd/action/PlatformPcdPreprocessAction.java +++ b/Tools/Source/PcdTools/org/tianocore/pcd/action/PlatformPcdPreprocessAction.java @@ -363,29 +363,6 @@ public abstract class PlatformPcdPreprocessAction { }
if (token.isDynamicPCD) {
- //
- // Check datum is equal the datum in dynamic information.
- // For dynamic PCD, you can do not write <Value> in sperated every <PcdBuildDefinition> in different <ModuleSA>,
- // But if you write, the <Value> must be same as the value in <DynamicPcdBuildDefinitions>.
- //
- if (!token.isSkuEnable() &&
- (token.getDefaultSku().type == DynamicTokenValue.VALUE_TYPE.DEFAULT_TYPE) &&
- (datum != null)) {
- if (!datum.equalsIgnoreCase(token.getDefaultSku().value)) {
- exceptionString = String.format("In the FPD file, for dynamic PCD %s in module %s, the datum in <ModuleSA> is "+
- "not equal to the datum type in <DynamicPcdBuildDefinitions>. This is "+
- "illega! You cannot set <Value> in <ModuleSA> for a dynamic PCD!",
- token.cName,
- moduleName);
- putError(exceptionString);
- //
- // Do not break preprocess, continues to analysis.
- // All errors will be summary to be shown.
- //
- continue;
- }
- }
-
if ((maxDatumSize != 0) &&
(maxDatumSize != token.datumSize)){
exceptionString = String.format("In the FPD file, for dynamic PCD %s in module %s, the max datum size is %d which "+
@@ -595,20 +572,6 @@ public abstract class PlatformPcdPreprocessAction { token.skuData.add(skuInstance);
- //
- // Judege wether is same of datum between module's information
- // and dynamic information.
- //
- if (datum != null) {
- if ((skuInstance.id == 0) &&
- !datum.toString().equalsIgnoreCase(skuInfoList.get(index).getValue().toString())) {
- exceptionString = "In the FPD file, for dynamic PCD " + token.cName + ", the value in module " + moduleName + " is " + datum.toString() + " but the "+
- "value of SKU 0 data in <DynamicPcdBuildDefinition> is " + skuInstance.value.value + ". They must be same!"+
- " Also, you cannot define a value for a dynamic PCD in the <ModuleSA> section!";
- putError(exceptionString);
- return null;
- }
- }
continue;
}
|