diff options
| author | Leif Lindholm <leif.lindholm@oss.qualcomm.com> | 2025-02-12 18:57:17 +0000 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2025-03-19 14:18:12 +0000 |
| commit | f6aba88ac8af6d4561a2f0f452e13564dde9d029 (patch) | |
| tree | c964c5a827c4e0d551fd6180d747714378695494 | |
| parent | 1c6ce560f042f70f4a8d7a26652ceab68b5df8d1 (diff) | |
| download | edk2-f6aba88ac8af6d4561a2f0f452e13564dde9d029.zip edk2-f6aba88ac8af6d4561a2f0f452e13564dde9d029.tar.gz edk2-f6aba88ac8af6d4561a2f0f452e13564dde9d029.tar.bz2 | |
MdeModulePkg/VarCheckHiiLib: don't return success for invalid input
The doxygen comment for VarCheckHiiLibReceiveHiiBinHandler says that
EFI_INVALID_PARAMETER should be returned if either of CommBuffer or
CommBufferSize is NULL, but the test results in an early return of
EFI_SUCCESS.
Update the code to match the documentation.
Signed-off-by: Leif Lindholm <leif.lindholm@oss.qualcomm.com>
| -rw-r--r-- | MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c index c1ee55b..2fe8ee7 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c @@ -58,7 +58,7 @@ VarCheckHiiLibReceiveHiiBinHandler ( // If input is invalid, stop processing this SMI
//
if ((CommBuffer == NULL) || (CommBufferSize == NULL)) {
- return EFI_SUCCESS;
+ return EFI_INVALID_PARAMETER;
}
mMmReceivedVarCheckHiiBinSize = *CommBufferSize;
|