summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Lubo <lubo.zhang@intel.com>2016-08-19 15:38:20 +0800
committerFu Siyuan <siyuan.fu@intel.com>2016-08-24 13:44:02 +0800
commitd82d59edb0ec23e6ef708e04a5553ac32f1eb12e (patch)
treef7b268850e897b0f458fc2879e76f95c2691f175
parent4962fcfa7d265824f01f74d782d5ed841ec8a72f (diff)
downloadedk2-d82d59edb0ec23e6ef708e04a5553ac32f1eb12e.zip
edk2-d82d59edb0ec23e6ef708e04a5553ac32f1eb12e.tar.gz
edk2-d82d59edb0ec23e6ef708e04a5553ac32f1eb12e.tar.bz2
MdeModulePkg:Fix bug in function AsciiStrToIp4.
If a FQDN contains 3 dots '.' like "a.b.c.com", the AsciiStrToIp4 will return success as the HostName has a valid IP address. So we need to check if it is a decimal character before using AsciiStrDecimalToUintn. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zhang@intel.com> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com> Reviewed-by: Ye Ting <ting.ye@intel.com> Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
-rw-r--r--MdeModulePkg/Library/DxeNetLib/DxeNetLib.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
index ef19439..7700f0ff 100644
--- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
+++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
@@ -2726,6 +2726,9 @@ NetLibAsciiStrToIp4 (
TempStr = Ip4Str;
while ((*Ip4Str != '\0') && (*Ip4Str != '.')) {
+ if (!NET_IS_DIGIT (*Ip4Str)) {
+ return EFI_INVALID_PARAMETER;
+ }
Ip4Str++;
}