diff options
| author | Michael Kubacki <michael.kubacki@microsoft.com> | 2025-05-13 11:06:35 -0700 |
|---|---|---|
| committer | Liming Gao <gaoliming@byosoft.com.cn> | 2025-07-01 09:53:09 +0800 |
| commit | d15b57292f345db25f1908c5ef43d0fd0c9d409e (patch) | |
| tree | a32946283e23ff337936af4af42dcb5af661b29f | |
| parent | 6cc56c6a2e2a1f9a40511811d23813847091a884 (diff) | |
| download | edk2-d15b57292f345db25f1908c5ef43d0fd0c9d409e.zip edk2-d15b57292f345db25f1908c5ef43d0fd0c9d409e.tar.gz edk2-d15b57292f345db25f1908c5ef43d0fd0c9d409e.tar.bz2 | |
MdeModulePkg: SectionExtractionPei cumulative codeql issues.
Running Codeql on MdeModulePkg/Universal/SectionExtractionPei drivers results
in codeql errors stemming from missing null tests.
Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Co-authored-by: Taylor Beebe <tabeebe@microsoft.com>
Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com>
Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com>
Co-authored-by: Oliver Smith-Denny <osde@linux.microsoft.com>
Co-authored-by: Sean Brogan <sean.brogan@microsoft.com>
Co-authored-by: Aaron <aaronpop@microsoft>
| -rw-r--r-- | MdeModulePkg/Universal/SectionExtractionPei/SectionExtractionPei.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/MdeModulePkg/Universal/SectionExtractionPei/SectionExtractionPei.c b/MdeModulePkg/Universal/SectionExtractionPei/SectionExtractionPei.c index 8a11643..5229fd8 100644 --- a/MdeModulePkg/Universal/SectionExtractionPei/SectionExtractionPei.c +++ b/MdeModulePkg/Universal/SectionExtractionPei/SectionExtractionPei.c @@ -251,12 +251,15 @@ SectionExtractionPeiEntry ( if (ExtractHandlerNumber > 0) {
GuidPpi = (EFI_PEI_PPI_DESCRIPTOR *)AllocatePool (ExtractHandlerNumber * sizeof (EFI_PEI_PPI_DESCRIPTOR));
ASSERT (GuidPpi != NULL);
- while (ExtractHandlerNumber-- > 0) {
- GuidPpi->Flags = EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST;
- GuidPpi->Ppi = (VOID *)&mCustomGuidedSectionExtractionPpi;
- GuidPpi->Guid = &ExtractHandlerGuidTable[ExtractHandlerNumber];
- Status = PeiServicesInstallPpi (GuidPpi++);
- ASSERT_EFI_ERROR (Status);
+
+ if (GuidPpi != NULL) {
+ while (ExtractHandlerNumber-- > 0) {
+ GuidPpi->Flags = EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST;
+ GuidPpi->Ppi = (VOID *)&mCustomGuidedSectionExtractionPpi;
+ GuidPpi->Guid = &ExtractHandlerGuidTable[ExtractHandlerNumber];
+ Status = PeiServicesInstallPpi (GuidPpi++);
+ ASSERT_EFI_ERROR (Status);
+ }
}
}
|