summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524>2012-09-12 07:18:50 +0000
committerjljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524>2012-09-12 07:18:50 +0000
commita1eff44b5ef7ef4cd96ecc54960dcfb18a455fb8 (patch)
treee2ae8ba9a4b2b9d5747b697955fb63ede9ba7e4f
parent830067bfa29358963dda22df935fefe7323f60b0 (diff)
downloadedk2-a1eff44b5ef7ef4cd96ecc54960dcfb18a455fb8.zip
edk2-a1eff44b5ef7ef4cd96ecc54960dcfb18a455fb8.tar.gz
edk2-a1eff44b5ef7ef4cd96ecc54960dcfb18a455fb8.tar.bz2
OvmfPkg: fix the mask for accessing the PIIX4 PMBA [15:6] bitfield
The Index Register Base Address bitfield is selected by the binary mask 00000000 00000000 11111111 11000000, 0xFFC0; fix the typo. Reported-by: Gleb Natapov <gleb@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13720 6f19259b-4bc3-4df7-8a09-765794883524
-rw-r--r--OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c2
-rw-r--r--OvmfPkg/PlatformPei/Platform.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c
index 027912e..8f4a5b3 100644
--- a/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c
+++ b/OvmfPkg/Library/AcpiTimerLib/AcpiTimerLib.c
@@ -60,7 +60,7 @@ AcpiTimerLibConstructor (
mPmba = PcdGet16 (PcdAcpiPmBaseAddress);
PciAndThenOr32 (PCI_LIB_ADDRESS (0,Device,3,0x40),
- (UINT32) ~0xfc0, mPmba);
+ (UINT32) ~0xFFC0, mPmba);
PciOr8 (PCI_LIB_ADDRESS (0,Device,3,0x04), 0x01);
}
diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c
index d91f113..589c5c3 100644
--- a/OvmfPkg/PlatformPei/Platform.c
+++ b/OvmfPkg/PlatformPei/Platform.c
@@ -230,7 +230,7 @@ MiscInitialization (
//
// Set the PM I/O base address to 0x400
//
- PciAndThenOr32 (PCI_LIB_ADDRESS (0, 1, 3, 0x40), (UINT32) ~0xfc0, 0x400);
+ PciAndThenOr32 (PCI_LIB_ADDRESS (0, 1, 3, 0x40), (UINT32) ~0xFFC0, 0x400);
}
}