diff options
| author | Marvin H?user <Marvin.Haeuser@outlook.com> | 2016-06-19 09:29:39 +0800 |
|---|---|---|
| committer | Liming Gao <liming.gao@intel.com> | 2016-06-22 09:37:12 +0800 |
| commit | 90eda6fc279744c3ab200c149e4b75ed0c5dabf0 (patch) | |
| tree | 3b59a235a4b160a085ca2a0ec3c17f15d32e78dc | |
| parent | 001f28caefbb2b5b05435adf36fc4e695b7b0f66 (diff) | |
| download | edk2-90eda6fc279744c3ab200c149e4b75ed0c5dabf0.zip edk2-90eda6fc279744c3ab200c149e4b75ed0c5dabf0.tar.gz edk2-90eda6fc279744c3ab200c149e4b75ed0c5dabf0.tar.bz2 | |
MdePkg/DebugLib: Flag post-_ASSERT() as unreachable for analyzers.
When a variable is compared to NULL as part of an ASSERT() call, the
code implies that the variable may be NULL. Certain Static Analyzers,
such as the Clang Static Analyzer, then issue false warnings for any
untested access of that pointer, even though that defeats the
intention behind ASSERT(). This patch flags the position after
_ASSERT() as unreachable for Static Analyzers to indicate that if the
variable is NULL, execution cannot pass.
As the ANALYZER-prefixed version is used, the executables will not
have any code stripped during compilation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
| -rw-r--r-- | MdePkg/Include/Library/DebugLib.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/DebugLib.h index 93b6f8d..803872c 100644 --- a/MdePkg/Include/Library/DebugLib.h +++ b/MdePkg/Include/Library/DebugLib.h @@ -291,6 +291,7 @@ DebugPrintLevelEnabled ( if (DebugAssertEnabled ()) { \
if (!(Expression)) { \
_ASSERT (Expression); \
+ ANALYZER_UNREACHABLE (); \
} \
} \
} while (FALSE)
|