summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKrzysztof Koch <krzysztof.koch@arm.com>2019-06-28 16:56:59 +0800
committerRay Ni <ray.ni@intel.com>2019-07-02 17:22:46 +0800
commit687546ddd5de9cf4c488d8485bbb15f62153a458 (patch)
tree24949e813be5add0b5939329f3200825bdfeedf6
parentf17dad04edab71426e43a7b7f0b9ae91404859e1 (diff)
downloadedk2-687546ddd5de9cf4c488d8485bbb15f62153a458.zip
edk2-687546ddd5de9cf4c488d8485bbb15f62153a458.tar.gz
edk2-687546ddd5de9cf4c488d8485bbb15f62153a458.tar.bz2
ShellPkg: acpiview: Remove '-v' flag from allowed command line args
According to the acpiview documentation, the -v flag enables verbose output and it is set on default. Moreover, the acpiview UEFI shell tool dumps the same output with and without this flag set. Therefore this patch removes the superfluous -v flag from allowed command line parameters. Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com> Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
-rw-r--r--ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c3
-rw-r--r--ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni3
2 files changed, 1 insertions, 5 deletions
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
index e99537a..911b2da 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
@@ -25,7 +25,6 @@ STATIC BOOLEAN mSelectedAcpiTableFound;
STATIC EREPORT_OPTION mReportType;
STATIC UINT32 mTableCount;
STATIC UINT32 mBinTableCount;
-STATIC BOOLEAN mVerbose;
STATIC BOOLEAN mConsistencyCheck;
STATIC BOOLEAN mColourHighlighting;
@@ -38,7 +37,6 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] = {
{L"-h", TypeValue},
{L"-l", TypeFlag},
{L"-s", TypeValue},
- {L"-v", TypeFlag},
{NULL, TypeMax}
};
@@ -472,7 +470,6 @@ ShellCommandRunAcpiView (
mSelectedAcpiTable = 0;
mSelectedAcpiTableName = NULL;
mSelectedAcpiTableFound = FALSE;
- mVerbose = TRUE;
mConsistencyCheck = TRUE;
ShellStatus = SHELL_SUCCESS;
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
index f061087..0d10b5d 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni
@@ -30,7 +30,7 @@
"Display ACPI Table information.\r\n"
".SH SYNOPSIS\r\n"
" \r\n"
-"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-v] [-h Highlight]]\r\n"
+"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-h Highlight]]\r\n"
" \r\n"
".SH OPTIONS\r\n"
" \r\n"
@@ -40,7 +40,6 @@
" AcpiTable : The required ACPI Table type.\r\n"
" -d - Generate a binary file dump of the specified AcpiTable.\r\n"
" -q - Quiet. Suppress errors and warnings. Disables consistency checks.\r\n"
-" -v - Display verbose data (enabled by default).\r\n"
" -h - Enable/Disable Colour Highlighting.\r\n"
" Highlight : TRUE/ON enables highlighting;\r\n"
" FALSE/OFF (default) disables highlighting.\r\n"