summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFan, ZhijuX <zhijux.fan@intel.com>2019-05-09 14:50:05 +0800
committerFeng, Bob C <bob.c.feng@intel.com>2019-05-09 19:02:35 +0800
commit49693202ec9cf2990507adeb5e088553dfcdc743 (patch)
treea0415ec717b00dcfe652b2f538c87e760df255c9
parent51e9be0cc3d154572ac93f2b1e133b2f6b163a82 (diff)
downloadedk2-49693202ec9cf2990507adeb5e088553dfcdc743.zip
edk2-49693202ec9cf2990507adeb5e088553dfcdc743.tar.gz
edk2-49693202ec9cf2990507adeb5e088553dfcdc743.tar.bz2
Revert "BaseTools:code of test python module is moved to edksetup"
This reverts commit df7c81b5b219c9aee776baa466dd64c9d318dd80. In commint df7c81b5b219c9,used a function to test python module But the Boolean value of the return value of this function is the opposite of the Correct result, resulting in an unexpected result Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-rw-r--r--BaseTools/Tests/RunTests.py8
-rwxr-xr-xedksetup.sh15
2 files changed, 10 insertions, 13 deletions
diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py
index e8acf1b..81af736 100644
--- a/BaseTools/Tests/RunTests.py
+++ b/BaseTools/Tests/RunTests.py
@@ -12,6 +12,14 @@
import os
import sys
import unittest
+
+try:
+ import distutils.util
+except ModuleNotFoundError:
+ sys.exit('''
+Python reported: "No module named 'distutils.util"
+''')
+
import TestTools
def GetCTestSuite():
diff --git a/edksetup.sh b/edksetup.sh
index ed9ceae..c7b2e1e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -177,22 +177,11 @@ function SetupPython()
SetupPython3
}
-function TestUtilModule()
-{
- if ( $PYTHON_COMMAND -c "import distutils.util" >/dev/null 2>&1 );then
- return 1
- else
- echo Error: "No module named 'distutils.util"
- return 0
- fi
-}
-
function SourceEnv()
{
SetWorkspace &&
- SetupEnv &&
- SetupPython &&
- TestUtilModule
+ SetupEnv
+ SetupPython
}
I=$#