summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason1 Lin <jason1.lin@intel.com>2025-03-13 20:44:29 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2025-03-13 15:39:06 +0000
commit1e0051e293aedc1a196ae5678a1e953e5ed946f1 (patch)
tree3a9d587a4eba90e50783e3c4e590ee9d992c5ec4
parent25ccb6ec548d7f72ad528ba5b735e91740816cf6 (diff)
downloadedk2-1e0051e293aedc1a196ae5678a1e953e5ed946f1.zip
edk2-1e0051e293aedc1a196ae5678a1e953e5ed946f1.tar.gz
edk2-1e0051e293aedc1a196ae5678a1e953e5ed946f1.tar.bz2
BaseTools: Fix Debug Macro Checking to Include Scanning Files
- In the commit 42a141800c0c26a09d2344e84a89ce4097a263ae there was a misuse of "is_dir" method. - Treating it as an object rather than function call, which caused if-condition to always as "false". - No files would be added to scanning list due to incorrect usage. - This patch corrects the issue by properly using "is_dir()". Signed-off-by: Jason1 Lin <jason1.lin@intel.com>
-rw-r--r--BaseTools/Plugin/DebugMacroCheck/DebugMacroCheck.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/BaseTools/Plugin/DebugMacroCheck/DebugMacroCheck.py b/BaseTools/Plugin/DebugMacroCheck/DebugMacroCheck.py
index 0d604c6..8b310e0 100644
--- a/BaseTools/Plugin/DebugMacroCheck/DebugMacroCheck.py
+++ b/BaseTools/Plugin/DebugMacroCheck/DebugMacroCheck.py
@@ -429,7 +429,7 @@ def check_macros_in_directory(directory: PurePath,
files = []
for file in root_directory.rglob('*'):
- if file.suffix in extensions and not file.is_dir:
+ if file.suffix in extensions and not file.is_dir():
files.append(Path(file))
# Give an indicator progress is being made