diff options
author | Ard Biesheuvel <ardb@kernel.org> | 2023-06-02 10:51:36 +0200 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2023-06-02 10:02:03 +0000 |
commit | 0364ccfeadd4c88445092cbed8be76d7c0315c52 (patch) | |
tree | bd63a1b2ff8420cbe5ce8419772c3b7fa34ae1bc | |
parent | a8acc12dfd80e4b2770c5912b1dbe1a04ab649d6 (diff) | |
download | edk2-0364ccfeadd4c88445092cbed8be76d7c0315c52.zip edk2-0364ccfeadd4c88445092cbed8be76d7c0315c52.tar.gz edk2-0364ccfeadd4c88445092cbed8be76d7c0315c52.tar.bz2 |
ArmPkg: Enable AuditMode for Uncrustify CI checks
Uncrustify checks are too rigid, making them counter-productive:
- it leads to code that is arguably harder to parse visually (e.g.,
the changes to ArmPkg/Include/Chipset/AArch64Mmu.h in commit
429309e0c6b74792)
- it forces indentation-only changes to code in the vicinity of actual
changes, making the code history more bloated than necessary (see
commit 7f198321eec0f520373 for an example)
- finding out from the web UI what exactly Uncrustify objected to is not
straight-forward.
So let's enable AuditMode for ArmPkg, so that interested parties can see
the uncrustify recommendations if desired, but without preventing the
changes from being merged. This leaves it at the discretion of the
ArmPkg maintainers to decide which level of conformance is required.
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
-rw-r--r-- | ArmPkg/ArmPkg.ci.yaml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml index 24db742..d312481 100644 --- a/ArmPkg/ArmPkg.ci.yaml +++ b/ArmPkg/ArmPkg.ci.yaml @@ -239,5 +239,10 @@ ],
"AdditionalIncludePaths": [] # Additional paths to spell check
# (wildcards supported)
+ },
+
+ # options defined in .pytool/Plugin/UncrustifyCheck
+ "UncrustifyCheck": {
+ "AuditOnly": True
}
}
|