diff options
| author | Sean Brogan <sean.brogan@microsoft.com> | 2021-06-16 00:53:57 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-07-09 08:29:54 +0000 |
| commit | f47c4676dd1a532b22a059cd036918abd6b0dd11 (patch) | |
| tree | 15e4e85bd4bb0c65014f8296ea4ac1bbf1ed7ad5 /.pytool | |
| parent | b560e9d9b67450d3baea56d0e211066722643c57 (diff) | |
| download | edk2-f47c4676dd1a532b22a059cd036918abd6b0dd11.zip edk2-f47c4676dd1a532b22a059cd036918abd6b0dd11.tar.gz edk2-f47c4676dd1a532b22a059cd036918abd6b0dd11.tar.bz2 | |
Pytool: SpellCheck: Defer path expansion in cspell parameters
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454
On Linux the shell expands the wildcard paths and causes multiple files
to be missed. This change adds additional quotes to defer expansion in
order to bring parity in cspell result.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Diffstat (limited to '.pytool')
| -rw-r--r-- | .pytool/Plugin/SpellCheck/SpellCheck.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/SpellCheck/SpellCheck.py index 9ad5763..05c471d 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -134,7 +134,8 @@ class SpellCheck(ICiBuildPlugin): #
relpath = os.path.relpath(abs_pkg_path)
cpsell_paths = " ".join(
- [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_check])
+ # Double quote each path to defer expansion to cspell parameters
+ [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_check])
# Make the config file
config_file_path = os.path.join(
|