aboutsummaryrefslogtreecommitdiff
path: root/unittests
diff options
context:
space:
mode:
authorXavier Claessens <xavier.claessens@collabora.com>2023-08-15 16:56:23 -0400
committerXavier Claessens <xclaesse@gmail.com>2023-09-18 13:51:27 -0400
commit30d7f506c7ffe4af52feab1a68263a4bd8d78c8a (patch)
tree132587c0d6c69e4cb066ac8c862bf8e75703f25e /unittests
parente0c4cffd70761c9b8176724145fb42d11e5313c4 (diff)
downloadmeson-30d7f506c7ffe4af52feab1a68263a4bd8d78c8a.zip
meson-30d7f506c7ffe4af52feab1a68263a4bd8d78c8a.tar.gz
meson-30d7f506c7ffe4af52feab1a68263a4bd8d78c8a.tar.bz2
Remove get_pkgconfig_variable()
Make sure that pkgconfig_define is a pair of strings and not a list with more than 2 strings.
Diffstat (limited to 'unittests')
-rw-r--r--unittests/failuretests.py2
-rw-r--r--unittests/linuxliketests.py12
2 files changed, 7 insertions, 7 deletions
diff --git a/unittests/failuretests.py b/unittests/failuretests.py
index ce58f3f..1fe29a2 100644
--- a/unittests/failuretests.py
+++ b/unittests/failuretests.py
@@ -242,7 +242,7 @@ class FailureTests(BasePlatformTests):
dep = declare_dependency(dependencies : zlib_dep)
dep.get_pkgconfig_variable('foo')
'''
- self.assertMesonRaises(code, "Method.*pkgconfig.*is invalid.*internal")
+ self.assertMesonRaises(code, ".*is not a pkgconfig dependency")
code = '''zlib_dep = dependency('zlib', required : false)
dep = declare_dependency(dependencies : zlib_dep)
dep.get_configtool_variable('foo')
diff --git a/unittests/linuxliketests.py b/unittests/linuxliketests.py
index 2de4dbc..cbce522 100644
--- a/unittests/linuxliketests.py
+++ b/unittests/linuxliketests.py
@@ -164,19 +164,19 @@ class LinuxlikeTests(BasePlatformTests):
self.assertTrue(foo_dep.found())
self.assertEqual(foo_dep.get_version(), '1.0')
self.assertIn('-lfoo', foo_dep.get_link_args())
- self.assertEqual(foo_dep.get_pkgconfig_variable('foo', [], None), 'bar')
- self.assertPathEqual(foo_dep.get_pkgconfig_variable('datadir', [], None), '/usr/data')
+ self.assertEqual(foo_dep.get_variable(pkgconfig='foo'), 'bar')
+ self.assertPathEqual(foo_dep.get_variable(pkgconfig='datadir'), '/usr/data')
libhello_nolib = PkgConfigDependency('libhello_nolib', env, kwargs)
self.assertTrue(libhello_nolib.found())
self.assertEqual(libhello_nolib.get_link_args(), [])
self.assertEqual(libhello_nolib.get_compile_args(), [])
- self.assertEqual(libhello_nolib.get_pkgconfig_variable('foo', [], None), 'bar')
- self.assertEqual(libhello_nolib.get_pkgconfig_variable('prefix', [], None), self.prefix)
+ self.assertEqual(libhello_nolib.get_variable(pkgconfig='foo'), 'bar')
+ self.assertEqual(libhello_nolib.get_variable(pkgconfig='prefix'), self.prefix)
impl = libhello_nolib.pkgconfig
if not isinstance(impl, PkgConfigCLI) or version_compare(PkgConfigCLI.check_pkgconfig(env, impl.pkgbin),">=0.29.1"):
- self.assertEqual(libhello_nolib.get_pkgconfig_variable('escaped_var', [], None), r'hello\ world')
- self.assertEqual(libhello_nolib.get_pkgconfig_variable('unescaped_var', [], None), 'hello world')
+ self.assertEqual(libhello_nolib.get_variable(pkgconfig='escaped_var'), r'hello\ world')
+ self.assertEqual(libhello_nolib.get_variable(pkgconfig='unescaped_var'), 'hello world')
cc = detect_c_compiler(env, MachineChoice.HOST)
if cc.get_id() in {'gcc', 'clang'}: