diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2021-08-31 09:55:01 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz93@gmail.com> | 2021-08-31 16:28:54 -0400 |
| commit | 4d7031437c7a81b52c776d4ae1e32741bdb851ca (patch) | |
| tree | 7716c4af0d3f43b450a7c94dd42ae5dbef8ebdff /packaging | |
| parent | 06fdb29daace9ebe55e5df5336f65cba304773d2 (diff) | |
| download | meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.zip meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.gz meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.bz2 | |
pylint: turn on superflous-parens
We have a lot of these. Some of them are harmless, if unidiomatic, such
as `if (condition)`, others are potentially dangerous `assert(...)`, as
`assert(condtion)` works as expected, but `assert(condition, message)`
will result in an assertion that never triggers, as what you're actually
asserting is `bool(tuple[2])`, which will always be true.
Diffstat (limited to 'packaging')
| -rwxr-xr-x | packaging/createpkg.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/packaging/createpkg.py b/packaging/createpkg.py index 95a7094..793d4bf 100755 --- a/packaging/createpkg.py +++ b/packaging/createpkg.py @@ -57,7 +57,7 @@ class PkgGenerator: os.makedirs(self.bindir) ln_base = os.path.relpath(self.mesonstashdir, self.bindir) ninja_bin = shutil.which('ninja') - assert(ninja_bin) + assert ninja_bin shutil.copy(ninja_bin, self.bindir) subprocess.check_call(['strip', os.path.join(self.bindir, 'ninja')]) os.symlink(os.path.join(ln_base, 'meson'), os.path.join(self.bindir, 'meson')) |