diff options
| author | Nirbheek Chauhan <nirbheek@centricular.com> | 2020-08-25 15:14:38 +0530 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek.chauhan@gmail.com> | 2020-08-27 00:13:58 +0000 |
| commit | 6f74692ae0fe4fda8a133cc1627c4742331a52c7 (patch) | |
| tree | f20ee2603e7e3c168f03e08220d6138ecd7c3bc3 /mesonbuild | |
| parent | 17439fa3e890266efeb0af1880640427be71a2ab (diff) | |
| download | meson-6f74692ae0fe4fda8a133cc1627c4742331a52c7.zip meson-6f74692ae0fe4fda8a133cc1627c4742331a52c7.tar.gz meson-6f74692ae0fe4fda8a133cc1627c4742331a52c7.tar.bz2 | |
Fix typo when fetching buildtype option for compiler checks
This type happened in https://github.com/mesonbuild/meson/pull/7432
and wasn't noticed because I didn't add a test for it. Rectified now.
If we don't specify the CRT, MSVC will pick /MT by default (!?) and
link to `libcmt.lib`. This actually *breaks* UWP because `libcmt.lib`
is not available by default when building for UWP.
Was noticed here: https://github.com/cisco/libsrtp/pull/505
Diffstat (limited to 'mesonbuild')
| -rw-r--r-- | mesonbuild/compilers/mixins/clike.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py index 77395bf..dfa3f8a 100644 --- a/mesonbuild/compilers/mixins/clike.py +++ b/mesonbuild/compilers/mixins/clike.py @@ -377,7 +377,7 @@ class CLikeCompiler: # us in that case and will error out asking us to pick one. try: crt_val = env.coredata.base_options['b_vscrt'].value - buildtype = env.coredata.base_options['buildtype'].value + buildtype = env.coredata.builtins['buildtype'].value cargs += self.get_crt_compile_args(crt_val, buildtype) except (KeyError, AttributeError): pass |