aboutsummaryrefslogtreecommitdiff
path: root/mesonbuild
diff options
context:
space:
mode:
authorPeter Kjellerstedt <pkj@axis.com>2021-03-03 12:47:28 +0100
committerJussi Pakkanen <jpakkane@gmail.com>2021-03-06 13:29:29 +0200
commit6226ac26ef63335bfb817db02b3f295c78214a82 (patch)
treee280e355a8cc5871f83cbedac9bb0e615a375b04 /mesonbuild
parentfcbab5948c364b2be9ba0d23f0c1ed9523adc9bb (diff)
downloadmeson-6226ac26ef63335bfb817db02b3f295c78214a82.zip
meson-6226ac26ef63335bfb817db02b3f295c78214a82.tar.gz
meson-6226ac26ef63335bfb817db02b3f295c78214a82.tar.bz2
minstall: Correctly set uid/gid of installed files
In commit caab4d3d, the uid and gid arguments passed to os.chown() by set_chown() were accidentally swapped, causing files to end up with incorrect owner/group if the owner and group are not the same. Also update the documentation to better indicate which argument to install_mode is which. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Diffstat (limited to 'mesonbuild')
-rw-r--r--mesonbuild/minstall.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/minstall.py b/mesonbuild/minstall.py
index 5713335..2a1883e 100644
--- a/mesonbuild/minstall.py
+++ b/mesonbuild/minstall.py
@@ -148,7 +148,7 @@ def set_chown(path: str, user: T.Optional[str] = None, group: T.Optional[str] =
Use a real function rather than a lambda to help mypy out. Also real
functions are faster.
"""
- real_os_chown(path, gid, uid, dir_fd=dir_fd, follow_symlinks=follow_symlinks)
+ real_os_chown(path, uid, gid, dir_fd=dir_fd, follow_symlinks=follow_symlinks)
try:
os.chown = chown