diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-07 14:59:47 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-11-30 16:23:29 -0500 |
| commit | 2d349eae8cb6f1f3b61838dca7cc989e9278be28 (patch) | |
| tree | bc8d6325543e0df74b16941996f07797a746a2f6 /mesonbuild/utils | |
| parent | 50f35039e7df321a309ee45db57d37635bf53ce3 (diff) | |
| download | meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.zip meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.gz meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.bz2 | |
pylint: enable the set_membership plugin
Which adds the `use-set-for-membership` check. It's generally faster in
python to use a set with the `in` keyword, because it's a hash check
instead of a linear walk, this is especially true with strings, where
it's actually O(n^2), one loop over the container, and an inner loop of
the strings (as string comparison works by checking that `a[n] == b[n]`,
in a loop).
Also, I'm tired of complaining about this in reviews, let the tools do
it for me :)
Diffstat (limited to 'mesonbuild/utils')
| -rw-r--r-- | mesonbuild/utils/universal.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/utils/universal.py b/mesonbuild/utils/universal.py index 4eafcd1..33c81c6 100644 --- a/mesonbuild/utils/universal.py +++ b/mesonbuild/utils/universal.py @@ -1002,7 +1002,7 @@ def get_library_dirs() -> T.List[str]: return unixdirs # FIXME: this needs to be further genericized for aarch64 etc. machine = platform.machine() - if machine in ('i386', 'i486', 'i586', 'i686'): + if machine in {'i386', 'i486', 'i586', 'i686'}: plat = 'i386' elif machine.startswith('arm'): plat = 'arm' |