diff options
| author | Florian Schmaus <flo@geekplace.eu> | 2020-11-16 12:41:02 +0100 |
|---|---|---|
| committer | Jussi Pakkanen <jpakkane@gmail.com> | 2020-11-17 17:50:27 +0200 |
| commit | 8bc656cccb2df30ab463699ebb8ad0a5c759ad17 (patch) | |
| tree | 8624438fe1df9fbd7a4b2ddd727ecff8a400557a /mesonbuild/scripts | |
| parent | 98ddd472ed42b27fd636857ca0e6895604029998 (diff) | |
| download | meson-8bc656cccb2df30ab463699ebb8ad0a5c759ad17.zip meson-8bc656cccb2df30ab463699ebb8ad0a5c759ad17.tar.gz meson-8bc656cccb2df30ab463699ebb8ad0a5c759ad17.tar.bz2 | |
Fix clang-tidy return value reporting (Part â…¡)
It turns out my first attempt to fix this in 00d5ef3191e5 ("Fix
clang-tidy return value reporting (#7949)") is not sufficient: The
local variable returncode is never updated and stays at 0. This fixes
the returncode calculation.
Fixes: cce172432be3 ("Use run-clang-tidy when available.")
Diffstat (limited to 'mesonbuild/scripts')
| -rw-r--r-- | mesonbuild/scripts/clangtidy.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/scripts/clangtidy.py b/mesonbuild/scripts/clangtidy.py index f920126..8d366c8 100644 --- a/mesonbuild/scripts/clangtidy.py +++ b/mesonbuild/scripts/clangtidy.py @@ -36,7 +36,7 @@ def manual_clangtidy(srcdir_name: str, builddir_name: str) -> int: if strf.startswith(builddir_name): continue futures.append(e.submit(subprocess.run, ['clang-tidy', '-p', builddir_name, strf])) - [max(returncode, x.result().returncode) for x in futures] + returncode = max([x.result().returncode for x in futures]) return returncode def clangtidy(srcdir_name: str, builddir_name: str) -> int: |