diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-07 14:03:41 -0700 |
---|---|---|
committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-11-29 23:26:05 -0500 |
commit | d5e899c76808d45854a06a4ba2b006da32480165 (patch) | |
tree | eb2f315230d2448edce06fa1a82666d683b2d6bb /mesonbuild/dependencies/cmake.py | |
parent | a5d547e0d9ccb523f0baab7fd32e782aa075fb42 (diff) | |
download | meson-d5e899c76808d45854a06a4ba2b006da32480165.zip meson-d5e899c76808d45854a06a4ba2b006da32480165.tar.gz meson-d5e899c76808d45854a06a4ba2b006da32480165.tar.bz2 |
pylint: enable the bad_builtin checker
This finds uses of deny-listed functions, which defaults to map and
filter. These functions should be replaced by comprehensions in
idiomatic python because:
1. comprehensions are more heavily optimized and are often faster
2. They avoid the need for lambdas in some cases, which make them
faster
3. you can do the equivalent in one statement rather than two, which
is faster
4. They're easier to read
5. if you need a concrete instance (ie, a list) then you don't have
to convert the iterator to a list afterwards
Diffstat (limited to 'mesonbuild/dependencies/cmake.py')
-rw-r--r-- | mesonbuild/dependencies/cmake.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/dependencies/cmake.py b/mesonbuild/dependencies/cmake.py index a035c7d..abd31a1 100644 --- a/mesonbuild/dependencies/cmake.py +++ b/mesonbuild/dependencies/cmake.py @@ -510,7 +510,7 @@ class CMakeDependency(ExternalDependency): # Try to use old style variables if no module is specified if len(libs) > 0: - self.compile_args = list(map(lambda x: f'-I{x}', incDirs)) + defs + self.compile_args = [f'-I{x}' for x in incDirs] + defs self.link_args = [] for j in libs: rtgt = resolve_cmake_trace_targets(j, self.traceparser, self.env, clib_compiler=self.clib_compiler) |