diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-07 15:23:42 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-10-04 00:33:04 -0400 |
| commit | a72840cd2e27bf18b88cf95ef6a9e5e3ab05427d (patch) | |
| tree | c3e6ce969bd01ae144f14213dd591e022c453019 /mesonbuild/dependencies/cmake.py | |
| parent | f11ebf20ff51dc1e9d6aa07fea64bc891869e48a (diff) | |
| download | meson-a72840cd2e27bf18b88cf95ef6a9e5e3ab05427d.zip meson-a72840cd2e27bf18b88cf95ef6a9e5e3ab05427d.tar.gz meson-a72840cd2e27bf18b88cf95ef6a9e5e3ab05427d.tar.bz2 | |
pylint: enable use-a-generator
This catches some optimization problems, mostly in the use of `all()`
and `any()`. Basically writing `any([x == 5 for x in f])` vs `any(x == 5
for x in f)` reduces the performance because the entire concrete list
must first be created, then iterated over, while in the second f is
iterated and checked element by element.
Diffstat (limited to 'mesonbuild/dependencies/cmake.py')
| -rw-r--r-- | mesonbuild/dependencies/cmake.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/dependencies/cmake.py b/mesonbuild/dependencies/cmake.py index e5443dd..a035c7d 100644 --- a/mesonbuild/dependencies/cmake.py +++ b/mesonbuild/dependencies/cmake.py @@ -272,7 +272,7 @@ class CMakeDependency(ExternalDependency): content = self._cached_listdir(i) candidates = ['Find{}.cmake', '{}Config.cmake', '{}-config.cmake'] candidates = [x.format(name).lower() for x in candidates] - if any([x[1] in candidates for x in content]): + if any(x[1] in candidates for x in content): return True return False |