diff options
author | Eli Schwartz <eschwartz@archlinux.org> | 2023-07-30 20:28:59 -0400 |
---|---|---|
committer | Dylan Baker <dylan@pnwbakers.com> | 2023-07-31 11:00:22 -0700 |
commit | d4615369ffbfc0f9a769ca1fd3566056cfa5ef81 (patch) | |
tree | 86e7999158fb1615ba84a78f6dd939ea33040532 /mesonbuild/coredata.py | |
parent | 404312c6ddc44b1e8f09a95a5c889184a25a384b (diff) | |
download | meson-d4615369ffbfc0f9a769ca1fd3566056cfa5ef81.zip meson-d4615369ffbfc0f9a769ca1fd3566056cfa5ef81.tar.gz meson-d4615369ffbfc0f9a769ca1fd3566056cfa5ef81.tar.bz2 |
fix lint errors revealed by pycodestyle 2.11
When performing isinstance checks, an identity comparison is
automatically done, but we don't use isinstance here because we need
strict identity equality *without allowing subtypes*.
Comparing type() == type() is a value comparison, but could produce
effectively the same results as an identity comparison, usually, despite
being semantically off. pycodestyle learned to detect this and warn you
to do strict identity comparison.
Diffstat (limited to 'mesonbuild/coredata.py')
-rw-r--r-- | mesonbuild/coredata.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/coredata.py b/mesonbuild/coredata.py index a6178f0..54d9b1d 100644 --- a/mesonbuild/coredata.py +++ b/mesonbuild/coredata.py @@ -807,7 +807,7 @@ class CoreData: continue oldval = self.options[key] - if type(oldval) != type(value): + if type(oldval) is not type(value): self.options[key] = value elif oldval.choices != value.choices: # If the choices have changed, use the new value, but attempt |