diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2021-02-05 09:02:26 -0800 |
|---|---|---|
| committer | Dylan Baker <dylan@pnwbakers.com> | 2021-02-05 16:31:33 -0800 |
| commit | 456844a4f36270e37da4da8cd61c385d4bfc745f (patch) | |
| tree | d4232e0b8141c2454b8cef9337462a6bb5cca935 /docs | |
| parent | d2c7063c1a69175b9874fddad62e6201c4913363 (diff) | |
| download | meson-456844a4f36270e37da4da8cd61c385d4bfc745f.zip meson-456844a4f36270e37da4da8cd61c385d4bfc745f.tar.gz meson-456844a4f36270e37da4da8cd61c385d4bfc745f.tar.bz2 | |
vala: Disable unity builds
Our approach to unity builds with vala is broken, you cannot unify the
generated C files, as they contain duplicate symbols. We would need to
instead combine the files while they are still in their vala form, then
convert that to C and compile the unified C file.
This does not fix the linked issue, as this removed the ability to do
vala unity builds, but it does allow running vala with `--unity=on`.
Related: #5280
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/markdown/snippets/vala_unity_builds_disabled.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/docs/markdown/snippets/vala_unity_builds_disabled.md b/docs/markdown/snippets/vala_unity_builds_disabled.md new file mode 100644 index 0000000..80e6523 --- /dev/null +++ b/docs/markdown/snippets/vala_unity_builds_disabled.md @@ -0,0 +1,7 @@ +## Unity build with Vala disabled + +The approach that meson has used for Vala unity builds is incorrect, we +combine the generated C files like we would any other C file. This is very +fragile however, as the Vala compiler generates helper functions and macros +which work fine when each file is a separate translation unit, but fail when +they are combined. |