aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJussi Pakkanen <jpakkane@gmail.com>2021-03-10 21:41:15 +0200
committerJussi Pakkanen <jpakkane@gmail.com>2021-03-10 21:41:15 +0200
commitbef540a3439934899b0c682c247af73d16e68050 (patch)
tree9695d7724dd0dcb1824d8bd6e51aa4006058c7db
parent4fda4f50120fb8464fdce279f970c70bd9526d96 (diff)
downloadmeson-nopipe.zip
meson-nopipe.tar.gz
meson-nopipe.tar.bz2
Remove -pipe from default list of args. Closes #8508.nopipe
-rw-r--r--docs/markdown/snippets/nopipe.md10
-rw-r--r--mesonbuild/compilers/mixins/clike.py2
-rw-r--r--mesonbuild/interpreter.py3
3 files changed, 11 insertions, 4 deletions
diff --git a/docs/markdown/snippets/nopipe.md b/docs/markdown/snippets/nopipe.md
new file mode 100644
index 0000000..431205b
--- /dev/null
+++ b/docs/markdown/snippets/nopipe.md
@@ -0,0 +1,10 @@
+## `-pipe` no longer used by default
+
+Meson used to add the `-pipe` command line argument to all compilers
+that supported it, but no longer does. If you need this, then you can
+add it manually. However note that you should not do this unless you
+have actually measured that it provides performance improvements. In
+our tests we could not find a case where adding `-pipe` made
+compilation faster and using `-pipe` [can cause sporadic build
+failures in certain
+cases](https://github.com/mesonbuild/meson/issues/8508).
diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py
index 787c2c1..87db2a4 100644
--- a/mesonbuild/compilers/mixins/clike.py
+++ b/mesonbuild/compilers/mixins/clike.py
@@ -154,7 +154,7 @@ class CLikeCompiler(Compiler):
'''
Args that are always-on for all C compilers other than MSVC
'''
- return ['-pipe'] + self.get_largefile_args()
+ return self.get_largefile_args()
def get_no_stdinc_args(self) -> T.List[str]:
return ['-nostdinc']
diff --git a/mesonbuild/interpreter.py b/mesonbuild/interpreter.py
index 68744ef..26d844d 100644
--- a/mesonbuild/interpreter.py
+++ b/mesonbuild/interpreter.py
@@ -4667,9 +4667,6 @@ different subdirectory.
elif arg == '-g':
mlog.warning(f'Consider using the built-in debug option instead of using "{arg}".',
location=self.current_node)
- elif arg == '-pipe':
- mlog.warning("You don't need to add -pipe, Meson will use it automatically when it is available.",
- location=self.current_node)
elif arg.startswith('-fsanitize'):
mlog.warning(f'Consider using the built-in option for sanitizers instead of using "{arg}".',
location=self.current_node)