diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2008-03-06 12:16:55 +1100 |
---|---|---|
committer | Jon Loeliger <jdl@loeliger.com> | 2008-03-23 08:00:33 -0500 |
commit | f7ea3708c38bd38851baafa83e98d95602e53cbc (patch) | |
tree | c6acbffa899a43be4336d7e695715c2fffcc8d60 /dtc.c | |
parent | 6c2e4d61f83af4233c3270e4f1ec1da01d90466e (diff) | |
download | dtc-f7ea3708c38bd38851baafa83e98d95602e53cbc.zip dtc-f7ea3708c38bd38851baafa83e98d95602e53cbc.tar.gz dtc-f7ea3708c38bd38851baafa83e98d95602e53cbc.tar.bz2 |
dtc: Make dtc_open_file() die() if unable to open requested file
All current callers of dtc_open_file() immediately die() if it returns
an error. In a non-interative tool like dtc, it's hard to see what
you could sensibly do to recover from a failure to open an input file
in any case.
Therefore, make dtc_open_file() itself die() if there's an error
opening the requested file. This removes the need for error checking
at the callsites, and ensures a consistent error message in all cases.
While we're at it, change the rror message from fstree.c when we fail
to open the input directory to match dtc_open_file()'s error message.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'dtc.c')
-rw-r--r-- | dtc.c | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -193,10 +193,6 @@ int main(int argc, char *argv[]) bi = dt_from_fs(arg); } else if(streq(inform, "dtb")) { inf = dtc_open_file(arg, NULL); - if (!inf) - die("Couldn't open \"%s\": %s\n", arg, - strerror(errno)); - bi = dt_from_blob(inf->file); } else { die("Unknown input format \"%s\"\n", inform); |