diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2022-05-14 08:50:10 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2022-05-25 21:25:42 +0200 |
commit | 3c7b72ddca9ce85a9d1e8a98fd0996b74597b5ae (patch) | |
tree | 608e8d89de8309ca384731aacfa98ea2c5d6df7a /util | |
parent | f8d426a6852c560fdd8648ae961c8189909a4b82 (diff) | |
download | qemu-3c7b72ddca9ce85a9d1e8a98fd0996b74597b5ae.zip qemu-3c7b72ddca9ce85a9d1e8a98fd0996b74597b5ae.tar.gz qemu-3c7b72ddca9ce85a9d1e8a98fd0996b74597b5ae.tar.bz2 |
thread-pool: optimize scheduling of completion bottom half
The completion bottom half was scheduled within the pool->lock
critical section. That actually results in worse performance,
because the worker thread can run its own small critical section
and go to sleep before the bottom half starts running.
Note that this simple change does not produce an improvement without
changing the thread pool QemuSemaphore to a condition variable.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Message-Id: <20220514065012.1149539-2-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'util')
-rw-r--r-- | util/thread-pool.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/util/thread-pool.c b/util/thread-pool.c index 196835b..4979f30 100644 --- a/util/thread-pool.c +++ b/util/thread-pool.c @@ -127,9 +127,8 @@ static void *worker_thread(void *opaque) smp_wmb(); req->state = THREAD_DONE; - qemu_mutex_lock(&pool->lock); - qemu_bh_schedule(pool->completion_bh); + qemu_mutex_lock(&pool->lock); } pool->cur_threads--; |