diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2023-06-06 15:56:39 +0400 |
|---|---|---|
| committer | Marc-André Lureau <marcandre.lureau@redhat.com> | 2023-06-27 17:08:56 +0200 |
| commit | 1d48c9fd8e4ab55662d8daec4af1d63cd2b54699 (patch) | |
| tree | ddd562c645955f949517bbbf7b7641fd1f7434db /ui/gtk-egl.c | |
| parent | 044ca4bf45b5bc232a2d699a9e63f359b1b85df6 (diff) | |
| download | qemu-1d48c9fd8e4ab55662d8daec4af1d63cd2b54699.zip qemu-1d48c9fd8e4ab55662d8daec4af1d63cd2b54699.tar.gz qemu-1d48c9fd8e4ab55662d8daec4af1d63cd2b54699.tar.bz2 | |
ui/egl: fix make_context_current() callback return value
eglMakeCurrent() returns 1/EGL_TRUE on success. This is not what the
callback expects, where 0 indicates success.
While at it, print the EGL error to ease debugging.
As with virgl_renderer_callbacks, the return value is now checked since
version >= 4:
https://gitlab.freedesktop.org/virgl/virglrenderer/-/commit/7f09e6bf0c6ceea6727bd0049781256a28cab0e5
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230606115658.677673-3-marcandre.lureau@redhat.com>
Diffstat (limited to 'ui/gtk-egl.c')
| -rw-r--r-- | ui/gtk-egl.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index e99e3b0..64dc0ee 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "qemu/main-loop.h" +#include "qemu/error-report.h" #include "trace.h" @@ -369,6 +370,11 @@ int gd_egl_make_current(DisplayGLCtx *dgc, { VirtualConsole *vc = container_of(dgc, VirtualConsole, gfx.dgc); - return eglMakeCurrent(qemu_egl_display, vc->gfx.esurface, - vc->gfx.esurface, ctx); + if (!eglMakeCurrent(qemu_egl_display, vc->gfx.esurface, + vc->gfx.esurface, ctx)) { + error_report("egl: eglMakeCurrent failed: %s", qemu_egl_get_error_string()); + return -1; + } + + return 0; } |