diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2018-12-04 18:20:05 +0400 |
|---|---|---|
| committer | Eduardo Habkost <ehabkost@redhat.com> | 2018-12-11 15:45:22 -0200 |
| commit | ef24052386d4a3c9cf10016cdf0f72b8a90728ae (patch) | |
| tree | 6379360880c9243ec2d691fb62f83ba909078c38 /tests | |
| parent | 112394af1ac21ee00c1bb9c487aca821434583ac (diff) | |
| download | qemu-ef24052386d4a3c9cf10016cdf0f72b8a90728ae.zip qemu-ef24052386d4a3c9cf10016cdf0f72b8a90728ae.tar.gz qemu-ef24052386d4a3c9cf10016cdf0f72b8a90728ae.tar.bz2 | |
tests: qdev_prop_check_globals() doesn't return "all_used"
Instead, it returns 1 if an error was detected, which is the case for:
/qdev/properties/dynamic/global/subprocess:
warning: global dynamic-prop-type-bad.prop3 has invalid class name
warning: global nohotplug-type.prop5=105 not used
warning: global nondevice-type.prop6 has invalid class name
Clarify the function return value.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20181204142023.15982-2-marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-qdev-global-props.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index d81b086..ccdf6c5 100644 --- a/tests/test-qdev-global-props.c +++ b/tests/test-qdev-global-props.c @@ -214,7 +214,7 @@ static void test_dynamic_globalprop_subprocess(void) { TYPE_NONDEVICE, "prop6", "106", true }, {} }; - int all_used; + int global_error; qdev_prop_register_global_list(props); @@ -223,8 +223,8 @@ static void test_dynamic_globalprop_subprocess(void) g_assert_cmpuint(mt->prop1, ==, 101); g_assert_cmpuint(mt->prop2, ==, 102); - all_used = qdev_prop_check_globals(); - g_assert_cmpuint(all_used, ==, 1); + global_error = qdev_prop_check_globals(); + g_assert_cmpuint(global_error, ==, 1); g_assert(props[0].used); g_assert(props[1].used); g_assert(!props[2].used); @@ -259,7 +259,7 @@ static void test_dynamic_globalprop_nouser_subprocess(void) { TYPE_NONDEVICE, "prop6", "106" }, {} }; - int all_used; + int global_error; qdev_prop_register_global_list(props); @@ -268,8 +268,8 @@ static void test_dynamic_globalprop_nouser_subprocess(void) g_assert_cmpuint(mt->prop1, ==, 101); g_assert_cmpuint(mt->prop2, ==, 102); - all_used = qdev_prop_check_globals(); - g_assert_cmpuint(all_used, ==, 0); + global_error = qdev_prop_check_globals(); + g_assert_cmpuint(global_error, ==, 0); g_assert(props[0].used); g_assert(props[1].used); g_assert(!props[2].used); |