aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2020-09-18 10:31:45 +0100
committerDaniel P. Berrangé <berrange@redhat.com>2020-10-29 09:57:37 +0000
commitdfc00eb7dea43bfb6d4a2ba38c4f6bc9745f3729 (patch)
treee3a211dae650c740c2f46f0c163e892e08b40280 /tests
parent77b7829e755aec2f74601190a4521617b6dab49c (diff)
downloadqemu-dfc00eb7dea43bfb6d4a2ba38c4f6bc9745f3729.zip
qemu-dfc00eb7dea43bfb6d4a2ba38c4f6bc9745f3729.tar.gz
qemu-dfc00eb7dea43bfb6d4a2ba38c4f6bc9745f3729.tar.bz2
util: include the target address in socket connect failures
Reporting "Failed to connect socket" is essentially useless for a user attempting to diagnose failure. It needs to include the target address details. Similarly when failing to create a socket we should include the socket family info, so the user understands what particular feature was missing in their kernel build (IPv6, VSock in particular). Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/qemu-iotests/162.out4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/qemu-iotests/162.out b/tests/qemu-iotests/162.out
index 5a00d36..f8714cb 100644
--- a/tests/qemu-iotests/162.out
+++ b/tests/qemu-iotests/162.out
@@ -6,8 +6,8 @@ image: nbd://localhost:PORT
image: nbd+unix://?socket=42
=== SSH ===
-qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": "0", "path": "/foo"}': Failed to connect socket: Connection refused
-qemu-img: Could not open 'driver=ssh,host=localhost,port=0,path=/foo': Failed to connect socket: Connection refused
+qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": "0", "path": "/foo"}': Failed to connect to 'localhost:0': Connection refused
+qemu-img: Could not open 'driver=ssh,host=localhost,port=0,path=/foo': Failed to connect to 'localhost:0': Connection refused
qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": 0.42, "path": "/foo"}': Parameter 'port' expects a number
qemu-img: Could not open 'driver=ssh,host=localhost,port=0.42,path=/foo': Parameter 'port' expects a number