diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-05-05 12:19:02 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-05-27 07:45:25 +0200 |
| commit | d01127584e70f9242d3dd9bf4c0bdc1980254713 (patch) | |
| tree | ed8f2f67b560d36bca85b8cb2d9c135a2224e584 /tests | |
| parent | 5e959d2e6e698af86a7064ead87ebe47706d99c7 (diff) | |
| download | qemu-d01127584e70f9242d3dd9bf4c0bdc1980254713.zip qemu-d01127584e70f9242d3dd9bf4c0bdc1980254713.tar.gz qemu-d01127584e70f9242d3dd9bf4c0bdc1980254713.tar.bz2 | |
tests/migration: Tighten error checking
migrate_get_socket_address() neglects to check
visit_type_SocketAddressList() failure. This smells like a leak, but
it actually will crash dereferencing @addrs. Pass &error_abort to
remove the code smell.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505101908.6207-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qtest/migration-test.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 2568c95..dc3490c 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "libqtest.h" +#include "qapi/error.h" #include "qapi/qmp/qdict.h" #include "qemu/module.h" #include "qemu/option.h" @@ -301,7 +302,6 @@ static char *migrate_get_socket_address(QTestState *who, const char *parameter) { QDict *rsp; char *result; - Error *local_err = NULL; SocketAddressList *addrs; Visitor *iv = NULL; QObject *object; @@ -310,7 +310,7 @@ static char *migrate_get_socket_address(QTestState *who, const char *parameter) object = qdict_get(rsp, parameter); iv = qobject_input_visitor_new(object); - visit_type_SocketAddressList(iv, NULL, &addrs, &local_err); + visit_type_SocketAddressList(iv, NULL, &addrs, &error_abort); visit_free(iv); /* we are only using a single address */ |