diff options
author | Alex Bennée <alex.bennee@linaro.org> | 2022-04-19 10:10:20 +0100 |
---|---|---|
committer | Alex Bennée <alex.bennee@linaro.org> | 2022-04-20 16:04:20 +0100 |
commit | caccf599181e2ea5f236345de9d9957a4c23e5ec (patch) | |
tree | 899db934099a1df91ca2b9668b7ac4cfdf2501c3 /tests | |
parent | e618e1f9b4cbb3803bbe70fae30a0fa4960f384d (diff) | |
download | qemu-caccf599181e2ea5f236345de9d9957a4c23e5ec.zip qemu-caccf599181e2ea5f236345de9d9957a4c23e5ec.tar.gz qemu-caccf599181e2ea5f236345de9d9957a4c23e5ec.tar.bz2 |
tests/guest-debug: better handle gdb crashes
There are a number of GDB's on various distros which fail fairly hard
when attempting to talk to a cross-arch guest. The previous attempt to
catch this was incorrect as the shell will deliver signals as 128+n.
Fix the detection and while we are it improve the logging we dump into
the test output.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reported-by: Gautam Agrawal <gautamnagrawal@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220419091020.3008144-26-alex.bennee@linaro.org>
Diffstat (limited to 'tests')
-rwxr-xr-x | tests/guest-debug/run-test.py | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py index 2e58795..d865e46 100755 --- a/tests/guest-debug/run-test.py +++ b/tests/guest-debug/run-test.py @@ -92,17 +92,18 @@ if __name__ == '__main__': result = subprocess.call(gdb_cmd, shell=True, stdout=output) - # A negative result is the result of an internal gdb failure like - # a crash. We force a return of 0 so we don't fail the test on + # A result of greater than 128 indicates a fatal signal (likely a + # crash due to gdb internal failure). That's a problem for GDB and + # not the test so we force a return of 0 so we don't fail the test on # account of broken external tools. - if result < 0: - print("GDB crashed? SKIPPING") + if result > 128: + log(output, "GDB crashed? (%d, %d) SKIPPING" % (result, result - 128)) exit(0) try: inferior.wait(2) except subprocess.TimeoutExpired: - print("GDB never connected? Killed guest") + log(output, "GDB never connected? Killed guest") inferior.kill() exit(result) |