diff options
| author | Peter Xu <peterx@redhat.com> | 2024-02-07 08:54:01 +0800 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-02-07 10:51:27 +0800 |
| commit | bdb0ade663c73270ceaec719c62f59bf049afbbe (patch) | |
| tree | 262409b8230622019f9b7f7c0179bc26e6cd59ba /tests | |
| parent | 93fa9dc2e0522c54b813dee0898a5feb98b624c9 (diff) | |
| download | qemu-bdb0ade663c73270ceaec719c62f59bf049afbbe.zip qemu-bdb0ade663c73270ceaec719c62f59bf049afbbe.tar.gz qemu-bdb0ade663c73270ceaec719c62f59bf049afbbe.tar.bz2 | |
tests/migration-test: Stick with gicv3 in aarch64 test
Recently we introduced cross-binary migration test. It's always wanted
that migration-test uses stable guest ABI for both QEMU binaries in this
case, so that both QEMU binaries will be compatible on the migration
stream with the cmdline specified.
Switch to a static gic version "3" rather than using version "max", so that
GIC should be stable now across any future QEMU binaries for migration-test.
Here the version can actually be anything as long as the ABI is stable. We
choose "3" because it's the majority of what we already use in QEMU while
still new enough: "git grep gic-version=3" shows 6 hit, while version 4 has
no direct user yet besides "max".
Note that even with this change, aarch64 won't be able to work yet with
migration cross binary test, but then the only missing piece will be the
stable CPU model.
Reviewed-by: "Daniel P. Berrangé" <berrange@redhat.com>
Link: https://lore.kernel.org/r/20240207005403.242235-2-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qtest/migration-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 7675519..8a5bb17 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -819,7 +819,7 @@ static int test_migrate_start(QTestState **from, QTestState **to, } else if (strcmp(arch, "aarch64") == 0) { memory_size = "150M"; machine_alias = "virt"; - machine_opts = "gic-version=max"; + machine_opts = "gic-version=3"; arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath); start_address = ARM_TEST_MEM_START; end_address = ARM_TEST_MEM_END; |