aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2020-05-13 23:52:30 -0400
committerPhilippe Mathieu-Daudé <philmd@redhat.com>2020-05-31 18:25:07 +0200
commit2d110c11497ac52d5ce9f4b116463cdb8c3f4ad5 (patch)
treefaf409f8ecaefb379907700e69938a5dfbe459fe /tests
parentc7b942d7f84ef54f266921bf7668d43f1f2c7c79 (diff)
downloadqemu-2d110c11497ac52d5ce9f4b116463cdb8c3f4ad5.zip
qemu-2d110c11497ac52d5ce9f4b116463cdb8c3f4ad5.tar.gz
qemu-2d110c11497ac52d5ce9f4b116463cdb8c3f4ad5.tar.bz2
python: remove more instances of sys.version_info
We guarantee 3.5+ everywhere; remove more dead checks. In general, try to avoid using version checks and instead prefer to attempt behavior when possible. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200514035230.25756-1-jsnow@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests')
-rwxr-xr-xtests/docker/docker.py5
-rwxr-xr-xtests/qemu-iotests/nbd-fault-injector.py5
2 files changed, 4 insertions, 6 deletions
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index d8268c1..5a9735d 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -258,12 +258,13 @@ class Docker(object):
return self._do_kill_instances(True)
def _output(self, cmd, **kwargs):
- if sys.version_info[1] >= 6:
+ try:
return subprocess.check_output(self._command + cmd,
stderr=subprocess.STDOUT,
encoding='utf-8',
**kwargs)
- else:
+ except TypeError:
+ # 'encoding' argument was added in 3.6+
return subprocess.check_output(self._command + cmd,
stderr=subprocess.STDOUT,
**kwargs).decode('utf-8')
diff --git a/tests/qemu-iotests/nbd-fault-injector.py b/tests/qemu-iotests/nbd-fault-injector.py
index 588d62a..78f42c4 100755
--- a/tests/qemu-iotests/nbd-fault-injector.py
+++ b/tests/qemu-iotests/nbd-fault-injector.py
@@ -47,10 +47,7 @@ import sys
import socket
import struct
import collections
-if sys.version_info.major >= 3:
- import configparser
-else:
- import ConfigParser as configparser
+import configparser
FAKE_DISK_SIZE = 8 * 1024 * 1024 * 1024 # 8 GB