aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2021-03-23 10:40:01 +0100
committerMarkus Armbruster <armbru@redhat.com>2021-03-23 21:39:12 +0100
commit27ae2f0787ae42eca9ec34961d2269d7a1fc5230 (patch)
tree8229de2afbfc70cdc978b601fcf333448ffccec6 /tests
parent5bd18d98cd88e2df1e1e274546a06ebe7fdd5eec (diff)
downloadqemu-27ae2f0787ae42eca9ec34961d2269d7a1fc5230.zip
qemu-27ae2f0787ae42eca9ec34961d2269d7a1fc5230.tar.gz
qemu-27ae2f0787ae42eca9ec34961d2269d7a1fc5230.tar.bz2
tests/qapi-schema: Belatedly update comment on alternate clash
Commit 0426d53c65 "qapi: Simplify visiting of alternate types" eliminated the implicit alternate enum, but neglected to update a comment about it in a test. Do that now. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20210323094025.3569441-5-armbru@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/qapi-schema/alternate-clash.err2
-rw-r--r--tests/qapi-schema/alternate-clash.json5
2 files changed, 2 insertions, 5 deletions
diff --git a/tests/qapi-schema/alternate-clash.err b/tests/qapi-schema/alternate-clash.err
index f58b977..0fe02f2 100644
--- a/tests/qapi-schema/alternate-clash.err
+++ b/tests/qapi-schema/alternate-clash.err
@@ -1,2 +1,2 @@
alternate-clash.json: In alternate 'Alt1':
-alternate-clash.json:7: branch 'a_b' collides with branch 'a-b'
+alternate-clash.json:4: branch 'a_b' collides with branch 'a-b'
diff --git a/tests/qapi-schema/alternate-clash.json b/tests/qapi-schema/alternate-clash.json
index 9a59b88..039c4be 100644
--- a/tests/qapi-schema/alternate-clash.json
+++ b/tests/qapi-schema/alternate-clash.json
@@ -1,8 +1,5 @@
# Alternate branch name collision
# Reject an alternate that would result in a collision in generated C
-# names (this would try to generate two enum values 'ALT1_KIND_A_B').
-# TODO: In the future, if alternates are simplified to not generate
-# the implicit Alt1Kind enum, we would still have a collision with the
-# resulting C union trying to have two members named 'a_b'.
+# names (this would try to generate two union members named 'a_b').
{ 'alternate': 'Alt1',
'data': { 'a-b': 'bool', 'a_b': 'int' } }