diff options
| author | Thomas Huth <thuth@redhat.com> | 2022-10-12 10:56:01 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2022-10-12 12:48:53 +0200 |
| commit | 04c92d2654b130fd29597a57ae2d71e70895bf2b (patch) | |
| tree | 40e06fdb33f634a88262ba099f834ec045872105 /tests/unit | |
| parent | 969d1f6e13fd34350b4b3fa72184e050ba77cd1c (diff) | |
| download | qemu-04c92d2654b130fd29597a57ae2d71e70895bf2b.zip qemu-04c92d2654b130fd29597a57ae2d71e70895bf2b.tar.gz qemu-04c92d2654b130fd29597a57ae2d71e70895bf2b.tar.bz2 | |
tests/unit/test-image-locking: Fix handling of temporary files
test-image-locking leaves some temporary files around - clean
them up. While we're at it, test-image-locking is a unit test,
so it should not use "qtest.*" for temporary file names. Give
them better names instead, so that it clear where the temporary
files come from.
Message-Id: <20221012085932.799221-1-thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/test-image-locking.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/unit/test-image-locking.c b/tests/unit/test-image-locking.c index a47299c..2624cec 100644 --- a/tests/unit/test-image-locking.c +++ b/tests/unit/test-image-locking.c @@ -79,7 +79,7 @@ static void test_image_locking_basic(void) g_autofree char *img_path = NULL; uint64_t perm, shared_perm; - int fd = g_file_open_tmp("qtest.XXXXXX", &img_path, NULL); + int fd = g_file_open_tmp("qemu-tst-img-lock.XXXXXX", &img_path, NULL); assert(fd >= 0); perm = BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ; @@ -120,7 +120,7 @@ static void test_set_perm_abort(void) g_autofree char *img_path = NULL; uint64_t perm, shared_perm; int r; - int fd = g_file_open_tmp("qtest.XXXXXX", &img_path, NULL); + int fd = g_file_open_tmp("qemu-tst-img-lock.XXXXXX", &img_path, NULL); assert(fd >= 0); perm = BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ; @@ -140,6 +140,8 @@ static void test_set_perm_abort(void) check_locked_bytes(fd, perm, ~shared_perm); blk_unref(blk1); blk_unref(blk2); + close(fd); + unlink(img_path); } int main(int argc, char **argv) |