diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-09-30 13:59:48 +0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-10-07 19:22:11 +0200 |
| commit | 1382d4abdf9619985e4078e37e49e487cea9935e (patch) | |
| tree | 7375d96c414975350045c389c72dcfc4e30124c5 /tests/qemu-iotests | |
| parent | eac8e79ff749fc15e1dca4caccf1f38664ab4915 (diff) | |
| download | qemu-1382d4abdf9619985e4078e37e49e487cea9935e.zip qemu-1382d4abdf9619985e4078e37e49e487cea9935e.tar.gz qemu-1382d4abdf9619985e4078e37e49e487cea9935e.tar.bz2 | |
qapi: return a 'missing parameter' error
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
parameters, but the qapi qmp_dispatch() code uses
QERR_INVALID_PARAMETER_TYPE.
Improve qapi code to return QERR_MISSING_PARAMETER where
appropriate.
Fix expected error message in iotests.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20160930095948.3154-4-marcandre.lureau@redhat.com>
[Drop incorrect error_setg() from qmp_input_type_any() and
qmp_input_type_null()]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/qemu-iotests')
| -rw-r--r-- | tests/qemu-iotests/087.out | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out index cd02eae..dc6baf9 100644 --- a/tests/qemu-iotests/087.out +++ b/tests/qemu-iotests/087.out @@ -56,7 +56,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on Testing: -S QMP_VERSION {"return": {}} -{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'driver', expected: string"}} +{"error": {"class": "GenericError", "desc": "Parameter 'driver' is missing"}} {"return": {}} {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"} |