diff options
author | John Snow <jsnow@redhat.com> | 2022-03-21 16:16:08 -0400 |
---|---|---|
committer | Hanna Reitz <hreitz@redhat.com> | 2022-03-22 10:14:31 +0100 |
commit | 9ebb2b765b0d6c6fd5228a736e31acfc10a56315 (patch) | |
tree | 9956298a213712d79f739ec51209b3505711329c /tests/qemu-iotests/iotests.py | |
parent | 0f7d7d72aa99c8e48bbbf37262a9c66c83113f76 (diff) | |
download | qemu-9ebb2b765b0d6c6fd5228a736e31acfc10a56315.zip qemu-9ebb2b765b0d6c6fd5228a736e31acfc10a56315.tar.gz qemu-9ebb2b765b0d6c6fd5228a736e31acfc10a56315.tar.bz2 |
iotests: add qemu_img_info()
Add qemu_img_info() by analogy with qemu_img_measure() and
qemu_img_check(). Modify image_size() to use this function instead to
take advantage of the better diagnostic information on failure provided
(ultimately) by qemu_img().
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220321201618.903471-9-jsnow@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/iotests.py')
-rw-r--r-- | tests/qemu-iotests/iotests.py | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 4725313..2a1c589 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -315,6 +315,9 @@ def qemu_img_measure(*args: str) -> Any: def qemu_img_check(*args: str) -> Any: return qemu_img_json("check", "--output", "json", *args) +def qemu_img_info(*args: str) -> Any: + return qemu_img_json('info', "--output", "json", *args) + def qemu_img_pipe(*args: str) -> str: '''Run qemu-img and return its output''' return qemu_img_pipe_and_status(*args)[0] @@ -565,10 +568,14 @@ def create_image(name, size): file.write(sector) i = i + 512 -def image_size(img): - '''Return image's virtual size''' - r = qemu_img_pipe('info', '--output=json', '-f', imgfmt, img) - return json.loads(r)['virtual-size'] +def image_size(img: str) -> int: + """Return image's virtual size""" + value = qemu_img_info('-f', imgfmt, img)['virtual-size'] + if not isinstance(value, int): + type_name = type(value).__name__ + raise TypeError("Expected 'int' for 'virtual-size', " + f"got '{value}' of type '{type_name}'") + return value def is_str(val): return isinstance(val, str) |