diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2018-05-08 14:54:36 +0100 |
|---|---|---|
| committer | Jeff Cody <jcody@redhat.com> | 2018-05-16 13:37:33 -0400 |
| commit | 4c7e813ce964e230bb55cf4afc862ccb091ca3a3 (patch) | |
| tree | 44504ffef0fa6b2e86e526418d775c93dcd60d10 /tests/qemu-iotests/185 | |
| parent | ddf2d98a94c8a98a661a217fb629cfd15f4dcec7 (diff) | |
| download | qemu-4c7e813ce964e230bb55cf4afc862ccb091ca3a3.zip qemu-4c7e813ce964e230bb55cf4afc862ccb091ca3a3.tar.gz qemu-4c7e813ce964e230bb55cf4afc862ccb091ca3a3.tar.bz2 | |
blockjob: do not cancel timer in resume
Currently the timer is cancelled and the block job is entered by
block_job_resume(). This behavior causes drain to run extra blockjob
iterations when the job was sleeping due to the ratelimit.
This patch leaves the job asleep when block_job_resume() is called.
Jobs can still be forcibly woken up using block_job_enter(), which is
used to cancel jobs.
After this patch drain no longer runs extra blockjob iterations. This
is the expected behavior that qemu-iotests 185 used to rely on. We
temporarily changed the 185 test output to make it pass for the QEMU
2.12 release but now it's time to address this issue.
Cc: QingFeng Hao <haoqf@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: QingFeng Hao <haoqf@linux.vnet.ibm.com>
Message-id: 20180508135436.30140-3-stefanha@redhat.com
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/185')
| -rwxr-xr-x | tests/qemu-iotests/185 | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/tests/qemu-iotests/185 b/tests/qemu-iotests/185 index 975404c..9a2d317 100755 --- a/tests/qemu-iotests/185 +++ b/tests/qemu-iotests/185 @@ -101,14 +101,11 @@ echo # command to be received (after receiving the command, the rest runs # synchronously, so jobs can arbitrarily continue or complete). # -# Jobs present while QEMU is terminating iterate once more due to -# bdrv_drain_all(). -# # The buffer size for commit and streaming is 512k (waiting for 8 seconds after # the first request), for active commit and mirror it's large enough to cover # the full 4M, and for backup it's the qcow2 cluster size, which we know is # 64k. As all of these are at least as large as the speed, we are sure that the -# offset advances exactly twice before qemu exits. +# offset advances exactly once before qemu exits. _send_qemu_cmd $h \ "{ 'execute': 'block-commit', |