diff options
| author | Max Reitz <mreitz@redhat.com> | 2017-11-10 21:31:07 +0100 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2017-11-17 18:21:30 +0100 |
| commit | 791fff504cad4d935dfaab6333ff9b7d95cbfe3f (patch) | |
| tree | 34b0d8dad955aad47c2a6882bbed8a045feaa1a8 /tests/qemu-iotests/060 | |
| parent | 3e3b838ffeba42eced87595b0a23dc38f7c0c21b (diff) | |
| download | qemu-791fff504cad4d935dfaab6333ff9b7d95cbfe3f.zip qemu-791fff504cad4d935dfaab6333ff9b7d95cbfe3f.tar.gz qemu-791fff504cad4d935dfaab6333ff9b7d95cbfe3f.tar.bz2 | |
qcow2: check_errors are fatal
When trying to repair a dirty image, qcow2_check() may apparently
succeed (no really fatal error occurred that would prevent the check
from continuing), but if check_errors in the result object is non-zero,
we cannot trust the image to be usable.
Reported-by: R. Nageswara Sastry <nasastry@in.ibm.com>
Buglink: https://bugs.launchpad.net/qemu/+bug/1728639
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20171110203111.7666-2-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/060')
| -rwxr-xr-x | tests/qemu-iotests/060 | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index fae08b03..56bdf1e 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotests/060 @@ -301,6 +301,26 @@ _make_test_img 64M poke_file "$TEST_IMG" "48" "\x00\x00\x00\x00\x00\x00\x00\x00" $QEMU_IO -c "write 0 64k" "$TEST_IMG" | _filter_qemu_io +echo +echo "=== Testing dirty corrupt image ===" +echo + +_make_test_img 64M + +# Let the refblock appear unaligned +poke_file "$TEST_IMG" "$rt_offset" "\x00\x00\x00\x00\xff\xff\x2a\x00" +# Mark the image dirty, thus forcing an automatic check when opening it +poke_file "$TEST_IMG" 72 "\x00\x00\x00\x00\x00\x00\x00\x01" +# Open the image (qemu should refuse to do so) +$QEMU_IO -c close "$TEST_IMG" 2>&1 | _filter_testdir | _filter_imgfmt + +echo '--- Repairing ---' + +# The actual repair should have happened (because of the dirty bit), +# but some cleanup may have failed (like freeing the old reftable) +# because the image was already marked corrupt by that point +_check_test_img -r all + # success, all done echo "*** done" rm -f $seq.full |