diff options
| author | Thomas Huth <thuth@redhat.com> | 2016-10-11 17:19:36 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2016-10-14 10:06:47 +1100 |
| commit | 3e353773721596971db2d0abc7015e7ea3d3af07 (patch) | |
| tree | 595bb7eac2c389f95fc441d2e4a3958899fb22a0 /tests/pxe-test.c | |
| parent | 1ef2ef96296f061c89b60e77c3c50577fd6fe415 (diff) | |
| download | qemu-3e353773721596971db2d0abc7015e7ea3d3af07.zip qemu-3e353773721596971db2d0abc7015e7ea3d3af07.tar.gz qemu-3e353773721596971db2d0abc7015e7ea3d3af07.tar.bz2 | |
tests/boot-sector: Use mkstemp() to create a unique file name
The pxe-test is run for three different targets now (x86_64, i386
and ppc64), and the bios-tables-test is run for two targets (x86_64
and i386). But each of the tests is using an invariant name for the
disk image with the boot sector code - so if the tests are running in
parallel, there is a race condition that they destroy the disk image
of a parallel test program. Let's use mkstemp() to create unique
temporary files here instead - and since mkstemp() is returning an
integer file descriptor instead of a FILE pointer, we also switch
the fwrite() and fclose() to write() and close() instead.
Reported-by: Sascha Silbe <x-qemu@se-silbe.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'tests/pxe-test.c')
| -rw-r--r-- | tests/pxe-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/pxe-test.c b/tests/pxe-test.c index 5d3ddbe..34282d3 100644 --- a/tests/pxe-test.c +++ b/tests/pxe-test.c @@ -19,7 +19,7 @@ #define NETNAME "net0" -static const char *disk = "tests/pxe-test-disk.raw"; +static char disk[] = "tests/pxe-test-disk-XXXXXX"; static void test_pxe_one(const char *params, bool ipv6) { |