diff options
| author | Peter Xu <peterx@redhat.com> | 2018-10-09 14:27:15 +0800 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-12-12 10:28:27 +0100 |
| commit | 8258292e18c39480b64eba9f3551ab772ce29b5d (patch) | |
| tree | c2e842bf2e48ff34e2b8b3fdd681ab48aeff1666 /tests/libqtest.c | |
| parent | 9ab84470ffc2781df3acd4607bc6d2ae64d6d7e3 (diff) | |
| download | qemu-8258292e18c39480b64eba9f3551ab772ce29b5d.zip qemu-8258292e18c39480b64eba9f3551ab772ce29b5d.tar.gz qemu-8258292e18c39480b64eba9f3551ab772ce29b5d.tar.bz2 | |
monitor: Remove "x-oob", offer capability "oob" unconditionally
Out-of-band command execution was introduced in commit cf869d53172.
Unfortunately, we ran into a regression, and had to turn it into an
experimental option for 2.12 (commit be933ffc23).
http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
The regression has since been fixed (commit 951702f39c7 "monitor: bind
dispatch bh to iohandler context"). A thorough re-review of OOB
commands led to a few more issues, which have also been addressed.
This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
and makes QMP monitors again offer capability "oob" whenever they can
provide it, i.e. when the monitor's character device is capable of
running in an I/O thread.
Some trivial touch-up in the test code is required to make sure qmp-test
won't break.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20181009062718.1914-4-peterx@redhat.com>
[Conflict with "monitor: check if chardev can switch gcontext for OOB"
resolved, commit message updated]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/libqtest.c')
| -rw-r--r-- | tests/libqtest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/libqtest.c b/tests/libqtest.c index 75e07e1..225a123 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -224,7 +224,7 @@ QTestState *qtest_init_without_qmp_handshake(bool use_oob, "-display none " "%s", qemu_binary, socket_path, getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null", - qmp_socket_path, use_oob ? ",x-oob=on" : "", + qmp_socket_path, "", extra_args ?: ""); g_test_message("starting QEMU: %s", command); |