aboutsummaryrefslogtreecommitdiff
path: root/target/xtensa/helper.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2019-04-17 21:17:57 +0200
committerMarkus Armbruster <armbru@redhat.com>2019-04-18 22:18:59 +0200
commit0442428a8976b4f94e04d24b5db9eb1b678d82c4 (patch)
treea4307320a5c4a5e6656c0f7ccf050c3db4edac57 /target/xtensa/helper.c
parentb6b71cb5c674a97a4cd935349ce8a2764f720af4 (diff)
downloadqemu-0442428a8976b4f94e04d24b5db9eb1b678d82c4.zip
qemu-0442428a8976b4f94e04d24b5db9eb1b678d82c4.tar.gz
qemu-0442428a8976b4f94e04d24b5db9eb1b678d82c4.tar.bz2
target: Simplify how the TARGET_cpu_list() print
The various TARGET_cpu_list() take an fprintf()-like callback and a FILE * to pass to it. Their callers (vl.c's main() via list_cpus(), bsd-user/main.c's main(), linux-user/main.c's main()) all pass fprintf() and stdout. Thus, the flexibility provided by the (rather tiresome) indirection isn't actually used. Drop the callback, and call qemu_printf() instead. Calling printf() would also work, but would make the code unsuitable for monitor context without making it simpler. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190417191805.28198-10-armbru@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'target/xtensa/helper.c')
-rw-r--r--target/xtensa/helper.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c
index f4867a9..5f37f37 100644
--- a/target/xtensa/helper.c
+++ b/target/xtensa/helper.c
@@ -31,6 +31,7 @@
#include "exec/gdbstub.h"
#include "exec/helper-proto.h"
#include "qemu/error-report.h"
+#include "qemu/qemu-print.h"
#include "qemu/host-utils.h"
static struct XtensaConfigList *xtensa_cores;
@@ -228,12 +229,12 @@ void xtensa_breakpoint_handler(CPUState *cs)
}
}
-void xtensa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
+void xtensa_cpu_list(void)
{
XtensaConfigList *core = xtensa_cores;
- cpu_fprintf(f, "Available CPUs:\n");
+ qemu_printf("Available CPUs:\n");
for (; core; core = core->next) {
- cpu_fprintf(f, " %s\n", core->config->name);
+ qemu_printf(" %s\n", core->config->name);
}
}