diff options
| author | David Hildenbrand <david@redhat.com> | 2021-09-03 17:55:09 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2021-09-06 16:24:05 +0200 |
| commit | 380ac2bcce466f3b8f93eb749c7e85bfcf476cd6 (patch) | |
| tree | b987e98e2b3ede78a69ecc7346c067986f98fa2f /target/s390x/mmu_helper.c | |
| parent | 390191c6f6e2e912f45bc312464d59b84ca12db3 (diff) | |
| download | qemu-380ac2bcce466f3b8f93eb749c7e85bfcf476cd6.zip qemu-380ac2bcce466f3b8f93eb749c7e85bfcf476cd6.tar.gz qemu-380ac2bcce466f3b8f93eb749c7e85bfcf476cd6.tar.bz2 | |
s390x/mmu_helper: avoid setting the storage key if nothing changed
Avoid setting the key if nothing changed.
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210903155514.44772-9-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'target/s390x/mmu_helper.c')
| -rw-r--r-- | target/s390x/mmu_helper.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index de6df92..e2b372e 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -301,7 +301,7 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags) { static S390SKeysClass *skeyclass; static S390SKeysState *ss; - uint8_t key; + uint8_t key, old_key; int rc; /* @@ -337,6 +337,7 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags) trace_get_skeys_nonzero(rc); return; } + old_key = key; switch (rw) { case MMU_DATA_LOAD: @@ -360,9 +361,11 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags) /* Any store/fetch sets the reference bit */ key |= SK_R; - rc = skeyclass->set_skeys(ss, addr / TARGET_PAGE_SIZE, 1, &key); - if (rc) { - trace_set_skeys_nonzero(rc); + if (key != old_key) { + rc = skeyclass->set_skeys(ss, addr / TARGET_PAGE_SIZE, 1, &key); + if (rc) { + trace_set_skeys_nonzero(rc); + } } } |