diff options
| author | Markus Armbruster <armbru@redhat.com> | 2021-07-20 14:54:01 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2021-08-26 17:15:28 +0200 |
| commit | 436c831a281ed950110dbc3e3baea24054c37298 (patch) | |
| tree | ba538a264b92b5598ec31e177423335f59b22738 /target/i386/whpx/whpx-all.c | |
| parent | 650126f838f763fe02f5b41584fd9f13cb8cbf13 (diff) | |
| download | qemu-436c831a281ed950110dbc3e3baea24054c37298.zip qemu-436c831a281ed950110dbc3e3baea24054c37298.tar.gz qemu-436c831a281ed950110dbc3e3baea24054c37298.tar.bz2 | |
migration: Unify failure check for migrate_add_blocker()
Most callers check the return value. Some check whether it set an
error. Functionally equivalent, but the former tends to be easier on
the eyes, so do that everywhere.
Prior art: commit c6ecec43b2 "qemu-option: Check return value instead
of @err where convenient".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210720125408.387910-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'target/i386/whpx/whpx-all.c')
| -rw-r--r-- | target/i386/whpx/whpx-all.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index cc8c0b9..3e925b9 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1346,8 +1346,7 @@ int whpx_init_vcpu(CPUState *cpu) "State blocked due to non-migratable CPUID feature support," "dirty memory tracking support, and XSAVE/XRSTOR support"); - (void)migrate_add_blocker(whpx_migration_blocker, &local_error); - if (local_error) { + if (migrate_add_blocker(whpx_migration_blocker, &local_error) < 0) { error_report_err(local_error); error_free(whpx_migration_blocker); ret = -EINVAL; |