diff options
| author | Claudio Fontana <cfontana@suse.de> | 2021-03-22 14:27:44 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2021-05-10 15:41:50 -0400 |
| commit | 9ea057dc641b150ecbfd45acfe18fe043641a551 (patch) | |
| tree | cff91686711453fcaf8e5d1a286feb4c81d69ab8 /target/i386/host-cpu.h | |
| parent | ce21726525da53053432b19e27e9fd2a49086d78 (diff) | |
| download | qemu-9ea057dc641b150ecbfd45acfe18fe043641a551.zip qemu-9ea057dc641b150ecbfd45acfe18fe043641a551.tar.gz qemu-9ea057dc641b150ecbfd45acfe18fe043641a551.tar.bz2 | |
accel-cpu: make cpu_realizefn return a bool
overall, all devices' realize functions take an Error **errp, but return void.
hw/core/qdev.c code, which realizes devices, therefore does:
local_err = NULL;
dc->realize(dev, &local_err);
if (local_err != NULL) {
goto fail;
}
However, we can improve at least accel_cpu to return a meaningful bool value.
Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210322132800.7470-9-cfontana@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'target/i386/host-cpu.h')
| -rw-r--r-- | target/i386/host-cpu.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/i386/host-cpu.h b/target/i386/host-cpu.h index b47bc09..6a9bc91 100644 --- a/target/i386/host-cpu.h +++ b/target/i386/host-cpu.h @@ -12,7 +12,7 @@ void host_cpu_instance_init(X86CPU *cpu); void host_cpu_max_instance_init(X86CPU *cpu); -void host_cpu_realizefn(CPUState *cs, Error **errp); +bool host_cpu_realizefn(CPUState *cs, Error **errp); void host_cpu_vendor_fms(char *vendor, int *family, int *model, int *stepping); |