aboutsummaryrefslogtreecommitdiff
path: root/target/i386/helper.h
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2020-06-25 23:58:31 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2020-07-10 18:02:17 -0400
commit418b0f93d12a1589d5031405de857844f32e9ccc (patch)
tree2684d445b3b701c9cd347b9f9ca0eec01bea393f /target/i386/helper.h
parent3ddc0eca2229846bfecc3485648a6cb85a466dc7 (diff)
downloadqemu-418b0f93d12a1589d5031405de857844f32e9ccc.zip
qemu-418b0f93d12a1589d5031405de857844f32e9ccc.tar.gz
qemu-418b0f93d12a1589d5031405de857844f32e9ccc.tar.bz2
target/i386: fix IEEE SSE floating-point exception raising
The SSE instruction implementations all fail to raise the expected IEEE floating-point exceptions because they do nothing to convert the exception state from the softfloat machinery into the exception flags in MXCSR. Fix this by adding such conversions. Unlike for x87, emulated SSE floating-point operations might be optimized using hardware floating point on the host, and so a different approach is taken that is compatible with such optimizations. The required invariant is that all exceptions set in env->sse_status (other than "denormal operand", for which the SSE semantics are different from those in the softfloat code) are ones that are set in the MXCSR; the emulated MXCSR is updated lazily when code reads MXCSR, while when code sets MXCSR, the exceptions in env->sse_status are set accordingly. A few instructions do not raise all the exceptions that would be raised by the softfloat code, and those instructions are made to save and restore the softfloat exception state accordingly. Nothing is done about "denormal operand"; setting that (only for the case when input denormals are *not* flushed to zero, the opposite of the logic in the softfloat code for such an exception) will require custom code for relevant instructions, or else architecture-specific conditionals in the softfloat code for when to set such an exception together with custom code for various SSE conversion and rounding instructions that do not set that exception. Nothing is done about trapping exceptions (for which there is minimal and largely broken support in QEMU's emulation in the x87 case and no support at all in the SSE case). Signed-off-by: Joseph Myers <joseph@codesourcery.com> Message-Id: <alpine.DEB.2.21.2006252358000.3832@digraph.polyomino.org.uk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'target/i386/helper.h')
-rw-r--r--target/i386/helper.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/target/i386/helper.h b/target/i386/helper.h
index 8f9e190..c2ae2f7 100644
--- a/target/i386/helper.h
+++ b/target/i386/helper.h
@@ -207,6 +207,7 @@ DEF_HELPER_FLAGS_2(pext, TCG_CALL_NO_RWG_SE, tl, tl, tl)
/* MMX/SSE */
DEF_HELPER_2(ldmxcsr, void, env, i32)
+DEF_HELPER_1(update_mxcsr, void, env)
DEF_HELPER_1(enter_mmx, void, env)
DEF_HELPER_1(emms, void, env)
DEF_HELPER_3(movq, void, env, ptr, ptr)