diff options
author | Sven Schnelle <svens@stackframe.org> | 2019-09-13 12:17:14 +0200 |
---|---|---|
committer | Richard Henderson <richard.henderson@linaro.org> | 2019-09-14 15:39:24 -0400 |
commit | a6deecce5b11827fff8a3de2142d02c5388aee1c (patch) | |
tree | 1a84322702fc45d6226d1f3468c647236aacdf12 /target/hppa | |
parent | 4845f01518fcc0b77f8b000651f9a5cc27d9f730 (diff) | |
download | qemu-a6deecce5b11827fff8a3de2142d02c5388aee1c.zip qemu-a6deecce5b11827fff8a3de2142d02c5388aee1c.tar.gz qemu-a6deecce5b11827fff8a3de2142d02c5388aee1c.tar.bz2 |
target/hppa: prevent trashing of temporary in do_depw_sar()
nullify_over() calls brcond which destroys all temporaries.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20190913101714.29019-3-svens@stackframe.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'target/hppa')
-rw-r--r-- | target/hppa/translate.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b12525d..c1b2822 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3404,10 +3404,6 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c, TCGv_reg mask, tmp, shift, dest; unsigned msb = 1U << (len - 1); - if (c) { - nullify_over(ctx); - } - dest = dest_gpr(ctx, rt); shift = tcg_temp_new(); tmp = tcg_temp_new(); @@ -3440,11 +3436,17 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c, static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a) { + if (a->c) { + nullify_over(ctx); + } return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r)); } static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a) { + if (a->c) { + nullify_over(ctx); + } return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a->i)); } |