diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2019-02-28 10:55:16 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2019-02-28 11:03:05 +0000 |
| commit | 942f99c825fc94c8b1a402fea128a41339cccee9 (patch) | |
| tree | 9f8051a5108734e2b2f3dc8e50f4faff8102b979 /target/arm/machine.c | |
| parent | c0c760afe800b60b48c80ddf3509fec413594778 (diff) | |
| download | qemu-942f99c825fc94c8b1a402fea128a41339cccee9.zip qemu-942f99c825fc94c8b1a402fea128a41339cccee9.tar.gz qemu-942f99c825fc94c8b1a402fea128a41339cccee9.tar.bz2 | |
Revert "arm: Allow system registers for KVM guests to be changed by QEMU code"
This reverts commit 823e1b3818f9b10b824ddcd756983b6e2fa68730,
which introduces a regression running EDK2 guest firmware
under KVM:
error: kvm run failed Function not implemented
PC=000000013f5a6208 X00=00000000404003c4 X01=000000000000003a
X02=0000000000000000 X03=00000000404003c4 X04=0000000000000000
X05=0000000096000046 X06=000000013d2ef270 X07=000000013e3d1710
X08=09010755ffaf8ba8 X09=ffaf8b9cfeeb5468 X10=feeb546409010756
X11=09010757ffaf8b90 X12=feeb50680903068b X13=090306a1ffaf8bc0
X14=0000000000000000 X15=0000000000000000 X16=000000013f872da0
X17=00000000ffffa6ab X18=0000000000000000 X19=000000013f5a92d0
X20=000000013f5a7a78 X21=000000000000003a X22=000000013f5a7ab2
X23=000000013f5a92e8 X24=000000013f631090 X25=0000000000000010
X26=0000000000000100 X27=000000013f89501b X28=000000013e3d14e0
X29=000000013e3d12a0 X30=000000013f5a2518 SP=000000013b7be0b0
PSTATE=404003c4 -Z-- EL1t
with
[ 3507.926571] kvm [35042]: load/store instruction decoding not implemented
in the host dmesg.
Revert the change for the moment until we can investigate the
cause of the regression.
Reported-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'target/arm/machine.c')
| -rw-r--r-- | target/arm/machine.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/arm/machine.c b/target/arm/machine.c index 124192b..b292549 100644 --- a/target/arm/machine.c +++ b/target/arm/machine.c @@ -630,7 +630,7 @@ static int cpu_pre_save(void *opaque) abort(); } } else { - if (!write_cpustate_to_list(cpu, false)) { + if (!write_cpustate_to_list(cpu)) { /* This should never fail. */ abort(); } |